Shows Deprecated error in wampserver

Question

I have been trying to show some results from an MySQL database, which has more than 5000 lines.

I have tried with 10 lines, the code works, but it shows warning like in the screenshot!!

Shows error in wampserver

Shows almost same error in online server as well Please help me to fix it , I have no knowledge in SQL.

Error

    <?php
    class DBController
    {
        private $host = "localhost";
        private $user = "user";
        private $password = "1234";
        private $database = "new1";



        function __construct()
        {
            $conn = $this->connectDB();
            if (!empty($conn)) {
                $this->selectDB($conn);
            }
        }

        function connectDB()
        {
            $conn = mysql_connect($this->host, $this->user, $this->password);
            return $conn;
        }

        function selectDB($conn)
        {
            mysql_select_db($this->database, $conn);
        }

        function runQuery($query)
        {
            $result = mysql_query($query);
            while ($row = mysql_fetch_assoc($result)) {
                $resultset[] = $row;
            }
            if (!empty($resultset))
                return $resultset;
        }

        function numRows($query)
        {
            $result   = mysql_query($query);
            $rowcount = mysql_num_rows($result);
            return $rowcount;
        }
    }
    ?>

Please check it

<?php
    function perpage($count, $per_page = '10',$href) {
        $output = '';
        $paging_id = "link_perpage_box";
        if(!isset($_POST["page"])) $_POST["page"] = 1;
        if($per_page != 0)
        $pages  = ceil($count/$per_page);
        if($pages>1) {

            if(($_POST["page"]-3)>0) {
                if($_POST["page"] == 1)
                    $output = $output . '<span id=1 class="current-page">1</span>';
                else                
                    $output = $output . '<input type="submit" name="page" class="perpage-link" value="1" />';
            }
            if(($_POST["page"]-3)>1) {
                    $output = $output . '...';
            }

            for($i=($_POST["page"]-2); $i<=($_POST["page"]+2); $i++)    {
                if($i<1) continue;
                if($i>$pages) break;
                if($_POST["page"] == $i)
                    $output = $output . '<span id='.$i.' class="current-page" >'.$i.'</span>';
                else                
                    $output = $output . '<input type="submit" name="page" class="perpage-link" value="' . $i . '" />';
            }

            if(($pages-($_POST["page"]+2))>1) {
                $output = $output . '...';
            }
            if(($pages-($_POST["page"]+2))>0) {
                if($_POST["page"] == $pages)
                    $output = $output . '<span id=' . ($pages) .' class="current-page">' . ($pages) .'</span>';
                else                
                    $output = $output . '<input type="submit" name="page" class="perpage-link" value="' . $pages . '" />';
            }

        }
        return $output;
    }

    function showperpage($sql, $per_page = 10, $href) {     
        $result  = mysqli_query($sql);
        $count   = mysqli_num_rows($result);
        $perpage = perpage($count, $per_page,$href);
        return $perpage;
    }

?>

err

**Please do not use `mysql_*` functions. That library existed a lot of years ago and is now deprecated.** Kindly use either `mysqli_*` or `PDO` instead. — Praveen Kumar Purushothaman, Mar 12 '16 at 09:47
See this for more info: http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php — Praveen Kumar Purushothaman, Mar 12 '16 at 09:49
This is not about SQL, but the PHP Programming Language and the implementations being used. `:(` You need to migrate the whole code to the new version. — Praveen Kumar Purushothaman, Mar 12 '16 at 09:50

score 2 · Accepted Answer · edited May 23 '17 at 10:28

2

Okay, taking the risk myself and answering the migrated code. Make sure you have MySQLi installed by checking with phpinfo();. Your new code:

<?php
    class DBController
    {
        private $host = "localhost";
        private $user = "user";
        private $password = "1234";
        private $database = "new1";
        private $conn;

        function __construct()
        {
            $this->conn = $this->connectDB();
            if (!empty($conn)) {
                $this->selectDB($conn);
            }
        }

        function connectDB()
        {
            $conn = mysqli_connect($this->host, $this->user, $this->password, $this->database);
            return $conn;
        }

        function runQuery($query)
        {
            $result = mysqli_query($this->conn, $query);
            while ($row = mysqli_fetch_assoc($result)) {
                $resultset[] = $row;
            }
            if (!empty($resultset))
                return $resultset;
            return false;
        }

        function numRows($query)
        {
            $result   = mysqli_query($this->conn, $query);
            $rowcount = mysqli_num_rows($this->conn, $result);
            return $rowcount;
        }
    }
?>

Notes:

New private variable $conn.
Now there's no select_db() function.
Added better return for runQuery.

Reason: Why shouldn't I use mysql_* functions in PHP?

Hope this helps.

edited May 23 '17 at 10:28

Community

1
1

answered Mar 12 '16 at 09:54

Praveen Kumar Purushothaman

164,888
24
203
252

1

Hah .. I'm glad to know you ... I have a lot of codes which need to be update to new version .. Can I paste them for you and you convert them for me ? `:-P` *(just kidding)* – Shafizadeh Mar 12 '16 at 10:00
1

@Shafizadeh Oh yea, well, please use my `Auto-PHP-MySQL-to-MySQLi-er` function! `:D` – Praveen Kumar Purushothaman Mar 12 '16 at 10:00
I think that worked , there are some other error , but I can work with them . Thanks – Archana P Mar 12 '16 at 10:12
@ArchanaP Let me know if there's any issues. – Praveen Kumar Purushothaman Mar 12 '16 at 10:21
Actually there is , can u help me with one more code ? The "Deprecated" error gone , but shows an error from another php file in index.php. (Warning: mysqli_query() expects at least 2 parameters, 1 given in C:\wamp\www\test\perpage.php on line 45) . May I post the code here ? – Archana P Mar 12 '16 at 10:25
@ArchanaP First parameter should be the connection object. Kindly give that. `:)` – Praveen Kumar Purushothaman Mar 12 '16 at 10:27
@ArchanaP I guess that would be a new question. But how can you have `[ – Praveen Kumar Purushothaman Mar 12 '16 at 10:31
@Praveen Kumar , I have posted the script with my main question . Kindly check . You are being helpful . Thank you. – Archana P Mar 12 '16 at 10:32
@ArchanaP See my comments above. – Praveen Kumar Purushothaman Mar 12 '16 at 10:32
@Praveen Kumar, [ – Archana P Mar 12 '16 at 10:33
@ArchanaP [edit] the post, delete the new content from `[ – Praveen Kumar Purushothaman Mar 12 '16 at 10:33
@ArchanaP I rolled back to however it was before, now paste the new contents just after the last line. – Praveen Kumar Purushothaman Mar 12 '16 at 10:35
@Praveen Kumar, it took some time !!! Please check it ... Error screen shot atatched – Archana P Mar 12 '16 at 10:39
@ArchanaP Change `$result = mysqli_query($sql);` to `$result = mysqli_query($conn, $sql);`. I assume `$conn` to hold the connection object, else recreate it using `$conn = mysqli_connect...` – Praveen Kumar Purushothaman Mar 12 '16 at 10:39
@Praveen Kumar, may i send you the full script ? in zip ? – Archana P Mar 12 '16 at 10:46
@Praveen Kumar, I have copied it , I will send you the full script including database . Thanks – Archana P Mar 12 '16 at 10:49
@Praveen Kumar, Please check your mail – Archana P Mar 12 '16 at 10:53
@ArchanaP Gotcha... `:)` – Praveen Kumar Purushothaman Mar 12 '16 at 13:02
@ArchanaP Working on it. – Praveen Kumar Purushothaman Mar 12 '16 at 14:13
@Praveen Kumar, `:-(` – Archana P Mar 13 '16 at 03:44

Shows Deprecated error in wampserver

1 Answers1