0
i = 0
numbers = []

while i < 6:
    print "at the top i is %d" % i
    numbers.append(i)
    i = i + 1
    print "Numbers now:", numbers
    print "At the bottom i is %d" %i

print "numbers:"

for num in numbers:
    print num

This version can work correctly, but I modify this but can not work correctly, as follows:

i = 0
numbers = []
start_num = raw_input('>>>')

def show_num(start_num):
global i
while i < start_num:
    print "At the top i is %d" %i
    numbers.append(i)
    i += 1
    print "Number now: ", numbers
    print "At the bottom i is %d" %i


show_num(start_num)

The correct result is:

at the top i is 0
Numbers now: [0]
At the bottom i is 1
at the top i is 1
Numbers now: [0, 1]
At the bottom i is 2
at the top i is 2
Numbers now: [0, 1, 2]
At the bottom i is 3
at the top i is 3
Numbers now: [0, 1, 2, 3]
At the bottom i is 4
at the top i is 4
Numbers now: [0, 1, 2, 3, 4]
At the bottom i is 5
at the top i is 5
Numbers now: [0, 1, 2, 3, 4, 5]
At the bottom i is 6
numbers:
0
1
2
3
4

but the second code shows the infinite one plus one plus...

Why does the second code fail?

Benjamin W.
  • 46,058
  • 19
  • 106
  • 116
yiping
  • 55
  • 1
  • 8

2 Answers2

2

raw_input takes input as string

you need to do 

start_num = int(raw_input('>>>'))
Hackaholic
  • 19,069
  • 5
  • 54
  • 72
0

Hackaholic has already answered your question, but I would like to give a few suggestions.

This is a better place for a for loop, as doing it as you are now is considered unpythonic.

Also, %s is an older way of doing things, I'd recommend using .format()

def show_num():
    start_num = int(raw_input('>>>'))
    numbers = []
    for i in range(start_num):
        print 'At the top i is {0}'.format(i)
        print 'At the bottom i is {0}'.format(i)
        numbers.append(i)
        print 'Numbers now:', numbers

show_num()
Jason
  • 2,278
  • 2
  • 17
  • 25
  • Thank for your sharing. I noticed in Learning Python the Hard Way shows different types use different %,like %d %s %r, and your method also need to change in different situations? And what is the {0} mean? It means format number? – yiping Mar 13 '16 at 05:26
  • Also http://stackoverflow.com/questions/13451989/pythons-many-ways-of-string-formatting-are-the-older-ones-going-to-be-deprec – tripleee Mar 13 '16 at 07:29