Update array elements (access using pointers) using scanf inputs in function

Question

So I have a pointer and a size of the array that gets passed down to a function that asks for user input and stores user input as array elements.

So the function looks like this:

int addElements(int * ptr, int sizeArr) {

int k=0;
for (k=0; k<=size; k++) {
    printf("please enter element number %d\n", k);
    scanf("%d", *(ptr+k));
}

return pArr;

}

It returns a pointer because I need to work further with the array.

I get

Segmentation fault (Core dumped)

error when inputting the elements to the array.

What am I doing wrong here? I can update the array elements (from random/automatic values ) to 0 just fine it's just the scanf that can't write to the array.

`pArr` or `ptr`? Also, in your loop `k` will be `size`in the last pass, which isn't a valid index for an array of size `size`. — M Oehm, Mar 16 '16 at 12:50
Edited it. It should've been *(ptr+k)..but as you guys explained: just ptr+k. — Bruce Strafford, Mar 16 '16 at 13:07

score 1 · Answer 1 · edited May 23 '17 at 11:53

ptr is a pointer to int.

(ptr + k) is still a pointer to (a different) int. *(ptr + k) is an int.

scanf( "%d", <some_int> ) will interpret the number stored in that int as an address, and try to write whatever the user entered to that "address".

Which is undefined behaviour.

You probably want to omit the * turning the pointer into an int; the statement would be well-formed then.

Generally speaking, recommended reading: How to read / parse input in C.

Check the return value of scanf(), as the user might have entered something that is not a number.
Cater for not-a-number input still waiting in the input buffer by reading up to the next newline, or subsequent scanf( "%d", ... ) will fail as well.
Better yet, read lines of input (with fgets()), and parse them in-memory (with strtol()), which allows you to recover from faulty input more gracefully.

Hi. Thanks for the explanation and for the link. I'm just learning C and pointers and arrays are taking a while to ge tused to. — Bruce Strafford, Mar 16 '16 at 13:08

Marievi · Accepted Answer · 2016-03-16T12:59:51.677

1

Modify the way you read elements by changing

scanf("%d", *(ptr+k));

with

scanf("%d", (ptr+k));

Scanf needs a pointer next to the specifier, but ptr is already a pointer (and so is ptr+k ) so by using the asterisk you imply the contents of the pointer and not the pointer itself.

edited Mar 16 '16 at 12:59

answered Mar 16 '16 at 12:53

Marievi

4,951
1
16
33

Some programmer dude · Answer 3 · 2016-03-16T13:05:42.600

For any pointer (or array) pArr and index k the expression *(pArr + k) is equivalent to pArr[i].

The problem with that is that pArr[i] (and therefore *(pArr + k)) is not a pointer, which is required by scanf to work.

There are two solutions: The first is to continue using pointer arithmetic and then simply drop the dereference operator (so you pass only pArr + k to scanf); Or you use "normal" array indexing and add the address-of operator (as in &pArr[k]).

A little explanation about the alternatives. The expression pArr[k] gives you the value at index k in the array, to get a pointer to that value we add the address-of operator & and get &pArr[k].

And since pArr[k] is equivalent to *(pArr + k) then &pArr[k] would be equivalent to &*(pArr + k), but the address-of and dereference operator cancels each other out leaving you with pArr + k.

What is happening now with the code as shown in the question is that you get the value at index k (i.e. pArr[k]) and the compiler converts it to a pointer (it should give you a warning about it though) and then scanf write to the memory pointed to by that value. Since pArr[k] is not a valid pointer, it may even be uninitialized (and therefore have an indeterminate value) you will have undefined behavior.

Thanks for the explanation. – Bruce Strafford Mar 16 '16 at 13:10 — Bruce Strafford, Mar 16 '16 at 13:10

Update array elements (access using pointers) using scanf inputs in function

3 Answers3