Best way to separate code of AngularJs controller

Question

I have a question related to bulk code on a AngularJs controller I have a controller name with userDashboard.js and I have lots of methods api calling for data for example:

1) Charts - Chart 1 ,Chart 2 Chart 3 ... etc.

2) Table - Table 1, 2 etc...

3) Section - 1 , 2 , 3 ..

I want to make separate Js file with same controller to make code readable and understandably how can i achieve this.

Is it is working if i am using same controller name for the other file like:

controller1.js

use strict';
angular.module('onepgr')
  .controller('userDashboard',
  function ($scope,$routeParams, MyAppService,Excel,$timeout) {
   //API
   //Chart
  });

controller2.js

use strict';
    angular.module('onepgr')
      .controller('userDashboard',
      function ($scope,$routeParams, MyAppService,Excel,$timeout) {
      //Table function
      //API
      });

http://stackoverflow.com/questions/25819661/how-to-split-single-controller-in-multiple-js-files-in-angularjs — Sajan Mullappally, Mar 17 '16 at 06:25

score 1 · Answer 1 · edited Mar 10 '17 at 12:33

1

Do not duplicate controller, make new one, for common things create service/factory which will be injected to each controller and keep common business logic there.

edited Mar 10 '17 at 12:33

Opal

81,889
28
189
210

answered Mar 17 '16 at 07:47

hanskoff

182
13

score 0 · Answer 2 · answered Mar 17 '16 at 06:30

0

This is largely a matter of taste. Check Sajan Mullappallys comment.

Otherwise, johnpapa has a pretty nice guideline which is endorsed by the Angular team. https://github.com/johnpapa/angular-styleguide

See if that suits you are your team mates. You are the ones you have to live with the code, so it's you who have to decide what's good and what's not, for you.

answered Mar 17 '16 at 06:30

qwelyt

776
9
23

Yes ! there is 400 line of code for just showing 4 kind of chart data. – Anil Yadav Mar 17 '16 at 10:38
Thanks for your link – Anil Yadav Mar 17 '16 at 10:39

Best way to separate code of AngularJs controller

2 Answers2