is never assigned to, and will always have its default value 0

Question

I keep getting the above warning for both ordersubmitted and lastfillquantity, however everything seems to be working fine and when i print the the variables they seem to updating correctly.

public partial class Form1 : Form
{
    private bool ordersubmitted = false;
    private int lastfillquantity;

    private void SubmitOrder()
    {
        int lastfillquantity = e.filled;
        ordersubmitted = true
    }
}

Possible duplicate of [Field xxx is never assigned to, and will always have its default value null](http://stackoverflow.com/questions/4811155/field-xxx-is-never-assigned-to-and-will-always-have-its-default-value-null) — CompuChip, Mar 18 '16 at 16:34

score 3 · Accepted Answer · answered Mar 18 '16 at 16:33

You are not setting the value of the class property, instead you are creating a new property inside the method and assign the new value to that one. Try this:

public partial class Form1 : Form
{
    private bool ordersubmitted = false;
    private int lastfillquantity;

    private void SubmitOrder()
    {
        // here you need to assign it, instead of defining another class property
        lastfillquantity = e.filled;
        ordersubmitted = true
    }
}

Sami Kuhmonen · Answer 2 · 2016-03-18T16:34:57.120

2

It is not working fine. As it says, you are never setting a value for it. You just define another variable with the same name in the method and set its value, just to throw it away. The class field never gets any other value than zero.

edited Mar 18 '16 at 16:34

answered Mar 18 '16 at 16:31

Sami Kuhmonen

30,146
9
61
74

2

It's a class *field*. Variables don't exist on the class level. – Mar 18 '16 at 16:33

score 1 · Answer 3 · answered Mar 18 '16 at 16:35

value of lastfillquantity variable is never updated, since you redeclare lastfillquantity inside SubmitOrder method and update new variable's (which hides outer one) value. Instead you should update outer variable.

Try following

private void SubmitOrder()
{
    lastfillquantity = e.filled;
    ordersubmitted = true
}

is never assigned to, and will always have its default value 0

3 Answers3