NetworkOnMainThreadException android activity

Question

I am using this code to retrieve website data inside android activity.It is throwing android.os.networkonmainthreadexception

    try
        {
            URL url = new URL("https://enigmatic-woodland-35608.herokuapp.com/pager.json");
            URLConnection tc = url.openConnection();
            BufferedReader in = new BufferedReader(new InputStreamReader(
                    tc.getInputStream()));
            String line, newl = " ";
            while ((line = in.readLine()) != null) {
                newl += line.trim();
            }
            System.out.println("newl" + newl.trim());
        } catch (Exception e) {
            Log.e("exception", e.toString());
        }

Please give me a possible solution..

Android donot allow run long running operation on UIThread. You have to create Worker Thread by using AsyncTask or Thread — mubeen, Mar 19 '16 at 07:13
You should use AsyncTask to excute a long-operation task which independen on main UIThread. AsyncTask is safe way to do that — GiapLee, Mar 19 '16 at 07:17

Andan H M · Accepted Answer · 2016-03-19T11:20:59.473

Network oprations/call cannot be done in main thread. You need to run it from another thread , asynchronous task or an intent service

Note : All UI opration shoud be done onPostExecute,onPreExecute

The below code may help you to solve.

Call AsyncTask where you want

new PagerAsyncTask().execute();

class PagerAsyncTask extends AsyncTask<String,Void,String>{
            @Override
            protected void onPreExecute() {
                super.onPreExecute();
            }

        @Override
        protected String doInBackground(String... params) {
            StringBuilder sb=null;
            BufferedReader reader=null;
            String serverResponse=null;
            try {

                URL url = new URL(""https://enigmatic-woodland-35608.herokuapp.com/pager.json"");
                HttpURLConnection connection = (HttpURLConnection) url.openConnection();
                connection.setRequestProperty("Content-Type", "application/x-www-form-urlencoded");
                connection.setConnectTimeout(5000);
                connection.setRequestMethod("GET");
                connection.connect();
                int statusCode = connection.getResponseCode();
                //Log.e("statusCode", "" + statusCode);
                if (statusCode == 200) {
                    sb = new StringBuilder();
                    reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
                    String line;
                    while ((line = reader.readLine()) != null) {
                        sb.append(line + "\n");
                    }
                }

                connection.disconnect();
                if (sb!=null)
                    serverResponse=sb.toString();
            } catch (Exception e) {
                e.printStackTrace();
            } finally {
                if (reader != null) {
                    try {
                        reader.close();
                    } catch (Exception e) {
                        e.printStackTrace();
                    }
                }
            }
            return serverResponse;
        }

        @Override
        protected void onPostExecute(String s) {
            super.onPostExecute(s);
           //All your UI operation can be performed here
            //Response string can be converted to JSONObject/JSONArray like
            JSONObject response=new JSONObject(s);
            System.out.println(s);
        }
    }

Hi andan can u tell me how to retrieve values for the serverresponse as Jsonobject keys — Rohit Mishra, Mar 19 '16 at 11:36
I am using JSONObject response=new JSONObject(s); Iterator> keys = response.keys(); while( keys.hasNext() ) { String key = (String)keys.next(); — Rohit Mishra, Mar 19 '16 at 11:38
you can try like this http://stackoverflow.com/a/36099263/4597347 — Andan H M, Mar 19 '16 at 11:39

score 2 · Answer 2 · answered Mar 19 '16 at 07:13

2

Network operations can involve unpredictable delays. To prevent this from causing a poor user experience, always perform network operations on a separate thread from the UI.

Please check the doc.

answered Mar 19 '16 at 07:13

csenga

3,819
1
21
31

thanks!! it worked – Rohit Mishra Mar 19 '16 at 07:22

Arun Shankar · Answer 3 · 2016-03-20T10:43:50.007

I am using a NetworkOps util in my projects. Try it:

import android.content.Context;
import android.net.Uri;
import android.util.Log;

import com.csehelper.variables.Constants;
import com.csehelper.variables.Keys;
import com.csehelper.variables.Url;

import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.io.OutputStreamWriter;
import java.net.HttpURLConnection;
import java.net.ProtocolException;
import java.net.SocketTimeoutException;
import java.net.URL;
import java.util.ArrayList;

public class NetworkOps {
    public final String EXCEPTION = "~Exception~";
    /****************************
     * Method to Grab Source
     ****************************/
    public static String GrabSource(String URL) {
        return PostData(URL, null);
    }



    /**
     * *****************************************
     * Method to Grab Source code from URL
     * Posting Data
     * *****************************************
     */
    private static String PostData(String url, Uri.Builder uribuilder) {
        String Source;
       HttpURLConnection.setFollowRedirects(false);
        HttpURLConnection urlConnection = null;
        try {
            urlConnection = (HttpURLConnection) new URL(url).openConnection();
            urlConnection.setDoOutput(true);
            urlConnection.setConnectTimeout(10000);

            if(uribuilder != null) {
                String query = uribuilder.build().getEncodedQuery();

                OutputStream os = urlConnection.getOutputStream();
                BufferedWriter writer = new BufferedWriter(
                        new OutputStreamWriter(os, "UTF-8"));
                writer.write(query);
                writer.flush();
                writer.close();
                os.close();
            }

            urlConnection.connect();

            if (urlConnection.getResponseCode() == HttpURLConnection.HTTP_OK) {

                String line;
                StringBuilder builder = new StringBuilder();
                InputStreamReader isr = new InputStreamReader(
                        urlConnection.getInputStream());
                BufferedReader reader = new BufferedReader(isr);
                while ((line = reader.readLine()) != null) {
                    builder.append(line);
                }
                Source = builder.toString();
            } else {
                Source = EXCEPTION + "Server unreachable. Check network connection.";
            }
        } catch (SocketTimeoutException e) {
            Source = EXCEPTION + "Connection timed out.";
        } catch (java.net.UnknownHostException e) {
            Source = EXCEPTION + Constants.EXCEPTION_NO_NET;
        } catch (ArrayIndexOutOfBoundsException e) {
            Source = EXCEPTION + "Server error";
        } catch (ProtocolException e) {
            Source = EXCEPTION + "Protocol error";
        } catch (IOException e) {
            Source = EXCEPTION + "Server unreachable. Check network connection.";
        } catch (Exception e) {
            Source = EXCEPTION + "Error:" + e.toString() + " - "
                    + e.getMessage();
            e.printStackTrace();

        } finally {
            if (urlConnection != null) urlConnection.disconnect();
        }
        return Source;
    }


}

Call these Static Functions from AsyncTask:

/*********************************
 * AsyncTask to GrabSource
 ********************************/
class AsyncTask_GrabSource extends AsyncTask<Void, Void, Void> {

    String Source = null;
    String url = "https://enigmatic-woodland-35608.herokuapp.com/pager.json";
    @Override
    protected void onPreExecute() {
       //Runs on Main Thread. You can access your UI elements here.
    }

    @Override
    protected Void doInBackground(Void... params) {
        // Don't access any UI elements from this function
        Source = NetworkOps.GrabSource(this.url);
        return null;
    }

    @Override
    protected void onPostExecute(Void result) {
        if (Source != null) {
            if (!Source.contains(EXCEPTION)) {
                //Show Error Message or do whatever you want
            } else {
                //Do Whatever with your Grabbed Sourcecode.
                // This function runs on UI Thread, so you can update UI elements here
            }

    }
}

You can also post data with the function PostData. In method doInBackground, add this:

Uri.Builder builder = new Uri.Builder()
                    .appendQueryParameter("key", "value")
                    .appendQueryParameter("key2", "value2");

Source = NetworkOps.PostData(getApplicationContext(), url, builder);

NetworkOnMainThreadException android activity

3 Answers3

Linked