I am getting a syntax error with my mysql query code below

Question

Variable declaration:-

$firstname=""; 
$surname ="";
$id ="";
$faculty_of_study= "";
$enrolled_course ="";
$gender ="";
$password= "";
$telephone_no="";
$email_address=""; 
$sql="";

$firstname = addslashes($_POST["firstname"]);
$surname = addslashes($_POST["surname"]);
$id = addslashes($_POST["id"]); 
$faculty_of_study = addslashes($_POST["faculty_of_study"]);
$enrolled_course = addslashes($_POST["enrolled_course"]);
$gender = addslashes($_POST["gender"]);
$password = addslashes($_POST["password"]);
$telephone_no = addslashes($_POST["telephone_no"]);
$email_address = addslashes($_POST["email_address"]);
$sql = "INSERT INTO people (firstname, surname, id,faculty_of_study, enrolled_course, gender, password, telephone_no, email_address); VALUES ("$firstname", "$surname", "$id", "$faculty_of_study",  "$enrolled_course", "$gender","$password", "$telephone_no", "$email_address")";

syntax error unexpected '$firstname' (T_VARIABLE) on line 21

`"$firstname"` etc: => `'$firstname'` etc (single quoteds instead of doubles) — fusion3k, Mar 19 '16 at 11:30
Not related to the problem, but ***never*** use `addslashes` for database data; it does not offer any sort of real protection. `mysql_real_escape_string` would at least be better. — VoteyDisciple, Mar 19 '16 at 11:34
people are not interested in marking the answer. Wastage of effort and time.Deleting my answer. — Alive to die - Anant, Apr 06 '16 at 05:11

score 3 · Answer 1 · answered Mar 19 '16 at 11:30

3

Try This

 $sql = "INSERT INTO people (firstname, surname, id,   
 faculty_of_study, enrolled_course, gender, password, telephone_no, 
email_address) VALUES ('$firstname', '$surname', '$id',  
'$faculty_of_study',
'$enrolled_course', '$gender','$password', '$telephone_no','$email_address')";

answered Mar 19 '16 at 11:30

KAREN

388
2
10

2

See prepared statements. – Strawberry Mar 19 '16 at 11:37

score 0 · Answer 2 · answered Mar 19 '16 at 11:49

Try this

$sql = "INSERT INTO people (firstname, surname, id,faculty_of_study, enrolled_course, gender, password, telephone_no, email_address) VALUES ('".$firstname."', '".$surname."', '".$id."', '".$faculty_of_study."',  '".$enrolled_course."', '".$gender."','".$password."', '".$telephone_no."', '".$email_address."')";

and remove semicolon before VALUES.

I am getting a syntax error with my mysql query code below

2 Answers2