js: Multiple return in Ternary Operator

Question

For my task, I have a done a piece of code like to fetch the user details,

var data = userInfo.map(function (element) {
    if (element[9].search("Active") != -1) {
        return {
            'LastName': Capitalizefirstletter(element[1]),
            'FirstName': Capitalizefirstletter(element[2]),
            'UserName': element[3],
            'IsActiveUser': "True"
        };
    }
    else {
        return {
            'LastName': Capitalizefirstletter(element[1]),
            'FirstName': Capitalizefirstletter(element[2]),
            'UserName': element[3],
            'IsActiveUser': "False"
        };
    }
}

which is working properly and i can see all the details of all the user in variable data.

While re factoring, I was asked to implement this using Ternary Operator(No guess why I have to change like this,though that one works fine). So I tried like this, code executed but only NULL value I can see in variable data.

var data = userInfo.map(function (element) {
    (element[9].search("Active")) != -1  ? {
        'LastName': Capitalizefirstletter(element[1]),
        'FirstName': Capitalizefirstletter(element[2]),
        'UserName': element[3],
        'IsActiveUser': "True"
    } : {
        'LastName': Capitalizefirstletter(element[1]),
        'FirstName': Capitalizefirstletter(element[2]),
        'UserName': element[3],
        'IsActiveUser': "False"
    };
}

Can anyone help me on this?

Thanks in Advance

you are missing the `return` keyword – cl3m Mar 22 '16 at 07:57 — cl3m, Mar 22 '16 at 07:57
Where's the `return` keyword? – Pramod Karandikar Mar 22 '16 at 07:57 — Pramod Karandikar, Mar 22 '16 at 07:57
Yeah I have missed out that `return` – Jeya Suriya Muthumari Mar 22 '16 at 09:25 — Jeya Suriya Muthumari, Mar 22 '16 at 09:25

Nina Scholz · Accepted Answer · 2016-03-23T07:00:02.310

4

Since the difference is only one property (IsActiveUser), you can insert the comparison inside the object.

var data = userInfo.map(function (element) {
    return {
        'LastName': Capitalizefirstletter(element[1]),
        'FirstName': Capitalizefirstletter(element[2]),
        'UserName': element[3],
        'IsActiveUser': ~element[9].search("Active") ? "True": "False" // really a string?
    };
});

edited Mar 23 '16 at 07:00

answered Mar 22 '16 at 08:01

Nina Scholz

376,160
25
347
392

1

Since number of lines matters, i go with this. – Jeya Suriya Muthumari Mar 22 '16 at 09:19
1

@Agnes Gru Steven, thanks for the attempt to edit. you wer part rigt, there was a bracket wrong and one missing. – Nina Scholz Mar 23 '16 at 07:03
1

Thanks, This may helps others too. :) – Jeya Suriya Muthumari Mar 23 '16 at 07:39

score 3 · Answer 2 · answered Mar 22 '16 at 07:58

Your map function needs to return something on each iteration. Just add the return keyword:

var data = userInfo.map(function (element) {
    return (element[9].search("Active")) != -1  ? {
        'LastName': Capitalizefirstletter(element[1]),
        'FirstName': Capitalizefirstletter(element[2]),
        'UserName': element[3],
        'IsActiveUser': "True"
    } : {
        'LastName': Capitalizefirstletter(element[1]),
        'FirstName': Capitalizefirstletter(element[2]),
        'UserName': element[3],
        'IsActiveUser': "False"
    };
}

js: Multiple return in Ternary Operator

2 Answers2

Linked