Append url from text box and open new window using javascript

Question

An onclick function is supposed to fire up a new window with a string and the textbox value appended to the url, but it doesn't seem to work. (The string will populate another textbox in the new window. This however, functions properly.)

When I use window.location it works but I don't want the page to open in the same window.

I'm very new to Javascript, thank you for your help.

Javascript

function changeLocation(){
var textboxpw = document.getElementById("key");
window.open{'http://website.com?secret="+textboxpw.value), '_blank';}

HTML

<input type="text" name="key" id="key" />
<input type="submit" value="Go" onclick="changeLocation(); return false;" />

check this [URL](https://developer.mozilla.org/en-US/docs/Web/API/Window/open) — Willie Cheng, Mar 30 '16 at 02:42
another one [URL](http://stackoverflow.com/questions/14132122/open-url-in-new-window-with-javascript) ,hopefully it can help you — Willie Cheng, Mar 30 '16 at 02:45
Why are you using curly brackets to enclose the arguments to the `window.open()` function? Is that intentional? Are you doing that in your original code? — APerson, Mar 30 '16 at 02:47
use `url = encodeURIComponent('http://website.com?secret="+textboxpw.value');` for the url — Murad Hasan, Mar 30 '16 at 02:53

score 5 · Answer 1 · answered Mar 30 '16 at 02:53

5

function changeLocation(){
    var textboxpw = document.getElementById("key");
    window.open('http://website.com?secret='+encodeURIComponent(textboxpw.value), '_blank');
}

answered Mar 30 '16 at 02:53

v7d8dpo4

1,399
8
9

good use of `encodeURIComponent`. – Murad Hasan Mar 30 '16 at 02:57
I tried this, didn't open a window. – helenanananah Mar 30 '16 at 06:47
What happens when you call `changeLocation`? – v7d8dpo4 Mar 30 '16 at 06:53

Murad Hasan · Answer 2 · 2016-03-30T03:00:11.890

1

The encodeURIComponent() function encodes a URI component.

This function encodes special characters.

In addition, it encodes the following characters:

, / ? : @ & = + $ #

Example:

var uri = "http://w3schools.com/my test.asp?name=ståle&car=saab";
var res = encodeURIComponent(uri);

output:

http%3A%2F%2Fw3schools.com%2Fmy%20test.asp%3Fname%3Dst%C3%A5le%26car%3Dsaab

The open() method opens a new browser window.

syntax: window.open(URL,name,specs,replace)

If your code block works fine except new window then try:

function changeLocation(){
    textboxpw = document.getElementById("key");
    url = encodeURIComponent('http://website.com?secret='+textboxpw.value);
    window.open(url, '_blank');
}

edited Mar 30 '16 at 03:00

answered Mar 30 '16 at 02:54

Murad Hasan

9,565
2
21
42

Unfortunately it does not launch a new window. – helenanananah Mar 30 '16 at 06:48
did you see `If your code block works fine except new window then try` in my answer?? I didn't change anything in your code, just add a function. – Murad Hasan Mar 30 '16 at 06:50

Append url from text box and open new window using javascript

2 Answers2