static class instances unique to a request or a server in ASP.NET?

Question

 public sealed class UserLoginSingleton
{

     UserLoginCollection _userLoginCol = new UserLoginCollection();

    UserLoginSingleton()
    {
    }

    public static UserLoginSingleton Instance
    {
        get
        {
            IDictionary items = HttpContext.Current.Items;
            if (!items.Contains("TheInstance"))
            {
                items["TheInstance"] = new UserLoginSingleton();

            }
            return items["TheInstance"] as UserLoginSingleton;
        }
    }


    public void CreateUserObj(string xmlData)
    {
        _userLoginCol = (UserLoginCollection)_xmlUtil.Deserialize(xmlData, typeof(UserLoginCollection));
    }

    public UserLoginCollection getUserObj()
    {
        return _userLoginCol;
    }
}

Usage:

Page 1.aspx

UserLoginSingleton.Instance.CreateUserObj(xml);

Pase2.aspx:

UserLoginCollection userLoginCollection = UserLoginSingleton.Instance.getUserObj();

Followed the article here: link text

I set my collection object in page 1 and then do a response.redirect or click on link to get me to page 2.aspx. However, my singleton instance has no collection object i set. How do i persist my collection object across diff pages per each session?

I know static's wont work as every instance will see the object and i want that to specific per each user.

score 3 · Answer 1 · answered Dec 12 '08 at 18:46

The HttpContext.Items collection is per-request. So in your case when the user gets redirected to page2.aspx, the instance you created on page 1 is gone. For the same instance to be available across requests, you need to be using HttpContext.Session to store your instance.

score 0 · Answer 2 · answered Dec 12 '08 at 18:59

0

static fields are shared between requests. Watch out for the standard multi-threaded issues!

HttpContext instances are not shared between requests.

answered Dec 12 '08 at 18:59

Amy B

108,202
21
135
185

In the example given, he's not using any static fields. – Mike Powell Dec 12 '08 at 19:37
Right. If he wants the data to be shared (which he seems to want), he should use a static field. – Amy B Dec 12 '08 at 22:02
He wants it shared between requests on a per-user basis. Static fields are definitely *not* what he wants. :) – Mike Powell Dec 16 '08 at 03:03

score 0 · Answer 3 · answered Dec 12 '08 at 19:46

Maybe I need to rethink what I want to do. Basically my collection is a collection fo around different values for a drop down list. This is fed by the client and my web page needs to display it.

i figured the client could send it across to me as serialized data, i gave them the xsd, and they would send that to me asynchronously while logging on. Page 1 would receive the serialized data. the login page would log them in. once page1 has received the data, would deserialize into my strongly typed collection which in turn would be used to build a dropdown list in page2.aspx

why am i doing it in such a primitive way. my hands are tied by restriction and i am trying not to use session state to hold this object if i can avoid it.

each user login comes in with various options for the dropdown list. user 1 caan have 10 options and user 2 can have 200 options.

If you're trying to avoid Session for a web farm scenario I'd recommend either the ASP.NET State Server, or updating a table in the database (keyed by the login ID). — devstuff, Dec 15 '08 at 04:25

score 0 · Answer 4 · answered Dec 12 '08 at 20:25

Just to point out your singleton implementation is wrong, your singleton should be declared like this

public sealed class Singleton
{
    static readonly Singleton instance=new Singleton();

    // Explicit static constructor to tell C# compiler
    // not to mark type as beforefieldinit
    static Singleton()
    {
    }

    Singleton()
    {
    }

    public static Singleton Instance
    {
        get
        {
            return instance;
        }
    }
}

score 0 · Answer 5 · answered Dec 13 '08 at 19:19

Use a static method that reads the HttpSession instead of a static variable:


public class UserLoginController
{
    public static UserLoginController Instance
    {
        get
        {
            HttpSession session = HttpContext.Current.Session;
            if (session["UserLoginController"] == null)
            {
                session["UserLoginController"] = new UserLoginController();
            }
            return session["UserLoginController"] as UserLoginController;
        }
    }
}

static class instances unique to a request or a server in ASP.NET?

5 Answers5