I am trying to replace a string with another string

Question

So when I type:

function x(z) {
    if (z !== 'y') return ("There is an error!")

    z = z.replace(/y/g, 'Canada');

    return x(z);
}

x('y')

I receive make "There is an error". But I am trying to get it to say 'Canada'.

What's wrong with my code?

Thanks!

I'm not convinced this is worthy of 5 downvotes? Could the voters explain? It's basic but not badly explained. — Liam, Apr 04 '16 at 13:55
Possible duplicate of [Replacing all occurrences of a string in JavaScript](http://stackoverflow.com/questions/1144783/replacing-all-occurrences-of-a-string-in-javascript) — Ben Fransen, Apr 04 '16 at 13:57
@Liam I think they downvoted because this question is not clear enough, don't mind them! As long this user get good answers and your question is solved :)\ — node_modules, Apr 04 '16 at 13:57
@AndyLe It is down voted because it is not clearly explained. The main reason is because "replacing a string with a string" can be done like this: `myStr = "new stuff"`. That replaces the value of the string myStr with another string, which is word for word what you asked for. So there is clearly something you want to do besides just replacing a string with a string. Explain what you really want to accomplish. Another reason is because you have an if statement in the first line of your function that is not explained, very odd, and has no obvious reason for being there. — Matt C, Apr 04 '16 at 15:18

score 7 · Answer 1 · answered Apr 04 '16 at 13:53

7

You are unnecessarily making a recursive call there,

function x(z) {
  if (z !== 'y') return ("There is an error!")
  z = z.replace(/y/g, 'Canada');
  return z;
}

That is not required at all in your context.

answered Apr 04 '16 at 13:53

Rajaprabhu Aravindasamy

66,513
17
101
130

1

Hehe I only spotted this after your post! :D – Pogrindis Apr 04 '16 at 13:54

score 1 · Answer 2 · answered Apr 04 '16 at 13:54

1

I think this is what you want to do.

function x(z) {
    if (z !== 'y') return ("There is an error!")

    z = z.replace(/y/g, 'Canada');

    return z;
}

alert(x('y')); // Canada

answered Apr 04 '16 at 13:54

Akshay Khandelwal

1,570
11
19

Samundra · Answer 3 · 2016-04-04T14:09:01.730

0

Remove unnecessary call to x(z). See below

function x(z) {
    if (z !== 'y') return ("There is an error!");

    z = z.replace(/y/g, 'Canada');

    return z; // changed from return x(z), unnecessary recursion
}

console.log(x('y'));

edited Apr 04 '16 at 14:09

answered Apr 04 '16 at 13:57

Samundra

1,869
17
28

1

Please close `x('y')`, `return ("There is an error!")` and `return z` with a `;` – node_modules Apr 04 '16 at 13:58
x('y') here is shown as example. I usually test all my scripts inside the browsers script panel. – Samundra Apr 04 '16 at 14:03
It works, but it can causes errors with other scripts if not closed properly. This only a tip ;) @Samundra – node_modules Apr 04 '16 at 14:04
I understand your concern and I have made changes as per your suggestion. The script now logs output to the console. – Samundra Apr 04 '16 at 14:05

score 0 · Answer 4 · answered Apr 04 '16 at 13:58

0

Because z is already replaced with Canada at the second execution of the recursion. BTW, there is no point to use regex in your case.

function x(z) {
    if (z !== 'y') return ("There is an error!")
    z = z.replace('y', 'Canada');
}
x('y')

answered Apr 04 '16 at 13:58

Lewis

14,132
12
66
87

dkinzer · Answer 5 · 2016-04-04T15:08:00.747

0

That code is doing exactly what you are telling it to.

You're saying: return "There is an error!" if var z is not equal to 'y', otherwise call the same function with a value not equal to 'y'.

Then you're call the function with 'y'.

edited Apr 04 '16 at 15:08

answered Apr 04 '16 at 14:01

dkinzer

32,179
12
66
85

I am trying to replace a string with another string

5 Answers5