PHP select and insert

Question

How can i minimalize that PHP code? Or write it in an easier way?

    $res = mysqli_query($mysqlc, "SELECT id FROM admin_szallas") or die(mysqli_error($mysqlc));
while($row = mysqli_fetch_array($res)) {

    $szID = $row["id"];
    mysqli_query($mysqlc, "INSERT INTO admin_ertesitesek (szallasID, ido, uzenet, allapot, akcio) VALUES('$szID', '$ido', '$cim', '0', '$akcio')") or die(mysqli_error($mysqlc));  

}

I put my code to a forum and they said this is a working code, but very ugly — Noel Tompos, Apr 04 '16 at 14:19
well, beauty is in the eye of the beholder, wouldn't you agree? ;-) — Funk Forty Niner, Apr 04 '16 at 14:20
It's good for me, but if there was a lot of mysql request its not too slow? Sorry for my bad english. :/ — Noel Tompos, Apr 04 '16 at 14:21
What exactly are you trying to change here? What's *wrong* with the code that needs to be fixed? (Hint: Before identifying a problem *before* correcting it is usually the way to go.) At the very least, you could do something about that SQL injection vulnerability. That won't make the code "smaller", but it will make it "better". — David, Apr 04 '16 at 14:24

score 0 · Answer 1 · edited May 23 '17 at 12:24

0

People can see in here different problems.

Coding style of presented code.
Usage of procedural functions instead of object-oriented.
Usage of die() instead of Exceptions.

If you want to protect it from SQL Injection check out this topic.

edited May 23 '17 at 12:24

Community

1
1

answered Apr 04 '16 at 14:57

nass

382
1
6
19

PHP select and insert

1 Answers1