Boolean If statement only returning outside

Question

public static boolean stringToBoolean (String horv) { 
    if (horv == "H") {
        return true;
    } if (horv == "V") {
        return false;
    } else {
        return true;
    }

This is a small part of a program I am creating. The program is reading from a file and inputting the data into an array. For this part it is reading what will either be a "H" or "V" from the file and converting it to a boolean value. The problem is when I run the program I am only getting true for every value, even the ones that have a "V" as their variable.

`==` checks whether objects references are same. `.equals()` compares the values — Sanj, Apr 08 '16 at 06:10

score 2 · Answer 1 · answered Apr 08 '16 at 05:56

2

Change the code to be:

if ("H".equals(horv)) { return true; }
...

answered Apr 08 '16 at 05:56

KevinO

4,303
4
27
36

score 2 · Answer 2 · answered Apr 08 '16 at 05:58

2

Try This

public static boolean stringToBoolean (String horv) { 
    if ("H".equals(horv)) { // use equals method for string comparison 
        return true;
    } if ("V".equals(horv)) {
        return false;
    } else {
        return true;
    }

answered Apr 08 '16 at 05:58

Kaustubh Khare

3,280
2
32
48

score 1 · Answer 3 · answered Apr 08 '16 at 05:57

1

String variables should be compared with equals() method in java.

answered Apr 08 '16 at 05:57

Areca

1,292
4
11
21

Muhammad Suleman · Answer 4 · 2016-04-08T06:07:35.497

1

In Java you have compare String with a method equals() Like this

public static boolean stringToBoolean (String horv) { 
  if (horv.equals("H"))  return true;
  if (horv.equals("V"))  return false;
  return true;
}

edited Apr 08 '16 at 06:07

answered Apr 08 '16 at 05:58

Muhammad Suleman

2,892
2
25
33

Boolean If statement only returning outside

4 Answers4