How to change the value with a variable within a for loop?

Question

I have the following code:

$extraPhoto_1 = get_field('extra_photo_1');
$extraPhoto_2 = get_field('extra_photo_2');
$extraPhoto_3 = get_field('extra_photo_3');
$extraPhoto_4 = get_field('extra_photo_4');

But I would like to rewrite it with a for loop, but I can't figure out how to put a variable within the value field. What I have so far is:

  for($i = 1; $i < 5; $i++) {
            ${'extraPhoto_' . $i} = get_field('extra_photo_ . $i');
      }

I've tried with an array like this:

    $myfiles = array();

      for ($i = 1; $i < 5; $i++) {
        $myfiles["$extraPhoto_$i"] = get_field('extra_photo_ . $i');
      }

Nothing seems to fix my problem. I'v searched on the PHP website (variable variable).

`get_field('extra_photo_ '. $i);` Don't include the variable inside this `''` — aldrin27, Apr 08 '16 at 09:00
@aldrin27 your code won't work due to one-space-too-much thing — Marcin Orlowski, Apr 08 '16 at 09:05
@thijs-moens you should read this too: https://secure.php.net/manual/en/language.types.string.php , esp. 2nd note there. — Marcin Orlowski, Apr 08 '16 at 09:08

score 0 · Accepted Answer · edited Apr 08 '16 at 09:08

0

There is some bug in your code which not allowing. Use 'extra_photo_'. $i instead of 'extra_photo_. $i'

for($i = 1; $i < 5; $i++) {
            $extraPhoto_.$i = get_field('extra_photo_'. $i);
      }

edited Apr 08 '16 at 09:08

Marcin Orlowski

72,056
11
123
141

answered Apr 08 '16 at 09:05

Ajay

235
2
8

acutally he could also do it with double quotes like: "extraphoto_$i" – Tuncay Göncüoğlu Apr 08 '16 at 10:05

score 0 · Answer 2 · answered Apr 08 '16 at 09:13

You can build an array as defined below and than just call extract($myfiles) to access them as variables.

Again your syntax for the get field is incorrect you should append $i after the quotes.

$myfiles = array();

  for ($i = 1; $i < 5; $i++) {
    $myfiles["extraPhoto_".$i] = get_field('extra_photo_'.$i);
  }
extract($myfiles);

score 0 · Answer 3 · answered Apr 08 '16 at 09:26

If you want to create dynamic variable, use below code

for ($i = 1; $i < 5; $i++) {
     ${'extraPhoto_'.$i} = $_POST['extra_photo_'.$i];
 }

if you want to assign variables to array use below code.

for ($i = 1; $i < 5; $i++) {
    $myfiles["extraPhoto_$i"] = $_POST['extra_photo_'.$i];
    /// $myfiles["extraPhoto_$i"] = get_field('extra_photo_'.$i);
  }

and than to see if values are assign to new array or not, you can use below code.

echo "<pre>";print_r($myfiles);echo "</pre>";

How to change the value with a variable within a for loop?

3 Answers3