How to pass a PHP string as JS function parameter?

Question

I have this PHP code who send an URL as argument to a JS function :

<?php
$url="www.google.com";
echo '<input type="submit" name="btnfone" onclick="window.open('.$url.')" class="btn-style2" value="Viewmap"/>';
?>

When I test it, nothing append. But if I change the URL with an integer

$url=1234;

Then the argument is interpreted.

What's the solution ?

@ÁlvaroGonzález i putted www.google.com between " but it don't work. — SachaDee, Apr 08 '16 at 15:47
Well... think about the difference between `window.open(www.google.com)` and `window.open(1234)`... — deceze, Apr 08 '16 at 15:47
I tried with `window.open("www.google.com")` and it don't work — SachaDee, Apr 08 '16 at 15:49
Because you don't have a `www.google.com` subdirectory. Don't you mean `http://...` by chance? — Álvaro González, Apr 11 '16 at 07:04

score 2 · Accepted Answer · answered Apr 08 '16 at 15:46

2

Just add quotes and escape.

onclick="window.open(\''.$url.'\')"

answered Apr 08 '16 at 15:46

Kevin Urbainczyk

this would work, but really... it would be so much better to not do this in an echo.... – Cayce K Apr 08 '16 at 15:47
Thanks @CayceK it work. I need to do it with an echo cause I get the URL from a file. – SachaDee Apr 08 '16 at 15:54
@SachaDee ... you still don't need to echo the whole lot though - you could leave PHP first (`?>`) and do something like `` – CD001 Apr 08 '16 at 15:59
Thanks a lot I'll try ! – SachaDee Apr 08 '16 at 16:00

1 Answers1