okhttp not downloading the file

Question

I am using okhttp for downloading video from server. there is no error no exception but the file is not downloading every where but it seems as it is.

Here is the code:

OkHttpClient httpClient = new OkHttpClient();
Call call = httpClient.newCall(new Request.Builder().url("http://res.cloudinary.com/demo/video/upload/v1427018743/ygzxwxmflekucvqcrb8c.mp4").get().build());
 try {
        File file = new File(getCacheDir(), user_Videos.get(i).video_title+ ".mp4");
        OutputStream out = new FileOutputStream(file);
        Response response = call.execute();
        if (response.code() == 200) {
           InputStream inputStream = null;
           try {
                inputStream = response.body().byteStream();
                byte[] buff = new byte[1024 * 8];
                long downloaded = 0;
                long target = response.body().contentLength();

                 publishProgress(0L, target);
                 while (true) {
                      int readed = inputStream.read(buff);
                       if (readed == -1) {
                           break;
                                        }
                          //write buff
                     downloaded += readed;

              try {
                   out.write(buff,0,readed);

                  } catch (Exception e) {
                       e.printStackTrace();
                                        }
                   publishProgress(downloaded, target);
                     if (isCancelled()) {
                                            return false;
                                        }
                                    }
                                    return downloaded == target;
                                } catch (IOException ignore) {
                                    return false;
                                } finally {
                                    if (inputStream != null) {
                                        out.flush();
                                        out.close();
                                        inputStream.close();
                                    }
                                }
                            } else {
                                return false;
                            }
                        } catch (IOException e) {
                            e.printStackTrace();
                            return false;
                        }

The progress is showing correctly but video is not showing in directory.

Thanks.

`video is not showing in directory.`. How do you look in that directory? And what is the full path of that directory? — greenapps, Apr 11 '16 at 16:39
`Have you added the permission to write to the storage`. There is no permission needed for that directory. — greenapps, Apr 11 '16 at 16:59
this is the file path :/data/data/com.rev.rev/cache/Gold -en.mp4 besides that I searched on other places too. with file name. — Syeda Zunaira, Apr 12 '16 at 04:49

Syeda Zunaira · Accepted Answer · 2016-04-12T06:28:55.957

0

So there is no problem in my code but the path. Thanks @greenapps who made me think about path/ directory.

Basically I just change the path to a real one instead of cache and yup here is the video.

Changed this line

 File file = new File(getCacheDir(), user_Videos.get(i).video_title  + ".mp4");

to this

 File file = new File(Environment.getExternalStorageDirectory(), user_Videos.get(i).video_title+ ".mp4");

Thanks @greenapps for the clue.

edited Apr 12 '16 at 06:28

answered Apr 12 '16 at 05:38

Syeda Zunaira

5,191
3
38
70

You shouldn't hardcode `"/sdcard"`. You should also consider removing WRITE_EXTERNAL_STORAGE permission since it is a "dangerous" permission on Android 6.0+. – Jared Rummler Apr 12 '16 at 05:44
1

use `Environment.getExternalStorageDirectory().getPath()` instead. Hardcoding `"/sdcard"` will work on the majority of devices but it is most likely a symlink and may not exist on some devices. – Jared Rummler Apr 12 '16 at 05:53
than what about those devices on which it doesn't work? – Syeda Zunaira Apr 12 '16 at 05:57
1

use `Environment.getExternalStorageDirectory()` – Jared Rummler Apr 12 '16 at 06:23

okhttp not downloading the file

1 Answers1

Linked