Populate multi-select with php while loop from db

Question

The following worked on a local environment. Now that it's pushed live everything but these seems to work. Displays completely empty select boxes now no checks or blank labels just empty space in the "select options" drop down. select display

<?php
  $selected = array();
  $selected = explode(",",$fill['markets']);

  $condb = mysql_query("SELECT * FROM `countries`");
  $count = mysql_num_rows($condb);
  $countries = array();
  $str;

  while ($countries = mysql_fetch_array($condb))
  {
    $str = "option{$countries['id']}";
    echo "<option value='{$str}' ";
    if(in_array($str,$selected)) {
      echo "selected>";
      echo $countries['country'];
      echo "</option>";
    } else {
      echo ">";
      echo $countries['country'];
      echo "</option>";
    }
  }      
  ?>

try $countries = mysql_fetch_array($condb); or you can use just a while with: `while ($row = mysql_fetch_array($result)) {`, — cmnardi, Apr 12 '16 at 14:42
that's the second variable declared, and it contains the values. $i references the row by id / array element. Since it's an array of arrays it's "arraykey->arrayvalue" in this case row->column. I know it contains the values because if I echo them specifically/individually it prints them out. — Robert Wood, Apr 12 '16 at 14:45
`mysql_fetch_array` only returns *one* row at a time, not *all* rows of the result set. Thats why you only have one country listed. — bspellmeyer, Apr 12 '16 at 14:47

score 0 · Accepted Answer · edited May 23 '17 at 12:31

0

You should use while loop instead. You can declare $i outside the loop if you need it, Try the following code:

  $condb = mysql_query("SELECT * FROM `countries`");

  $i = 0;
   while($countries = mysql_fetch_array($condb)) {
    $str = 'option' . $i;
    echo "<option value='{$str}' ";
    if(in_array($str,$selected)) {
      echo "selected>";
      echo $countries['country'];
      echo "</option>";
    } else {
      echo ">";
      echo $countries['country'];
      echo "</option>";
    }
 $i++;
  }
  ?>
</select>

Note:

mysql_* is deprecated as of php-5.5. So instead use mysqli_* or PDO.
Why shouldn't I use mysql_* functions in PHP?

edited May 23 '17 at 12:31

Community

1
1

answered Apr 12 '16 at 14:48

mega6382

9,211
17
48
69

don't forget the $i, if you need – cmnardi Apr 12 '16 at 14:49
does mysql_fetch_array() automatically go down a row each time you call it within the context of a loop? Will it stop returning at the end of the DB? that's why I chose to use num_rows() with a for loop. – Robert Wood Apr 12 '16 at 14:55
@RobertWood `mysql_fetch_array()` is a forward only function, so on every run it gets the next row. – mega6382 Apr 12 '16 at 14:58
Ah, thanks. So if it returns the last row it returns null after that? – Robert Wood Apr 12 '16 at 15:00
@RobertWood Yes I suppose or maybe `false`. And if the answer was helpful please accept it. – mega6382 Apr 12 '16 at 15:01
Yea sorry, I accepted it. At work atm so it took a moment. – Robert Wood Apr 12 '16 at 15:54

Populate multi-select with php while loop from db

1 Answers1