Shorter version of this if statement

Question

I have the following:

$first = $index % 2 == 0 ? 'partial_one' : 'partial_two';
$last = $index % 2 == 0 ? 'partial_two' : 'partial_one';

I have a feeling there is a shorter way to do this. Anyone?

There is other community for this type of question, take a look of http://codereview.stackexchange.com/ — Jose Rojas, Apr 12 '16 at 17:34
Well, it can be made even shorter... but I don't really see why. — Joel Hinz, Apr 12 '16 at 17:36
Since it's `modulo 2` which only returns 1 or 0, you can just leave out `== 0`, but need to reverse the two strings on each line. — Paul, Apr 12 '16 at 17:44
You could do this. I don't recommend it. `$first = ($a && ($last = ($a = $index % 2 == 0) ? 'partial_one' : 'partial_two')) ? 'partial_two' : 'partial_one';` — Roger, Apr 12 '16 at 18:12

score 3 · Accepted Answer · answered Apr 12 '16 at 17:33

3

This is not shorter, but in my opinion more readable:

if ($index % 2 == 0) {
    $first = 'partial_one';
    $last = 'partial_two';
}
else {
    $first = 'partial_two';
    $last = 'partial_one';
}

answered Apr 12 '16 at 17:33

Andreas

Thanks! I went for this answer in the end, and also Paul's suggestion to get rid of == 0. Thanks for your responses, everyone! – Such Much Code Apr 12 '16 at 18:07

1 Answers1