Onclick function to open new window and count clicks

Question

I have a button on my page to open inserted link in a new tab. To be able to track visit and if visitor clicked that button, I am trying to add variable to onclick function.

Here is my button:

<a href="javascript:void(0);"  onClick="window.open('$link','_blank')">
<button type="button" class="btnbuy">Buy</button></a>

Here is what I am trying to do:

<a href="javascript:void(0);"  onClick="myFunction()">
<button type="button" class="btnbuy">Buy</button></a>

<script>
function myFunction() {
if(window.open("$link", "_blank")){
$isclicked = true;
} }
</script>

$sql=mysql_query("INSERT INTO stats (id,isclicked) VALUES ("","$isclicked"");

I just wrote this function to show what I am trying to do, so please don't care syntax errors.

Am I on the right way or should I try something else? Thanks for your helps.

how do you want to call mysql_query in javascript? your code is wrong in so many levels... — Tanuel Mategi, Apr 13 '16 at 07:13
sorry, edited. anyway, obviously I wasnt planing to call mysql_query in javascript. — kazata, Apr 13 '16 at 07:24

score 0 · Answer 1 · answered Apr 13 '16 at 07:13

0

No need to put an if() around any of it.

Just do all your logic prior to the window.open() call.

answered Apr 13 '16 at 07:13

Ohgodwhy

49,779
11
80
110

1

@TanuelMategi I'm sure that's just an example. I don't think OP is that naive. – Ohgodwhy Apr 13 '16 at 07:14

score 0 · Answer 2 · edited May 23 '17 at 12:24

I would suggest that you use JQuery instead of the onclick function.

That would mean your HTML can shorten down to

<button type="button" class="btnbuy">Buy</button>

Your JQuery would be something like

$(".btnbuy").on('click',function(){
alert("clicked")
/*AJAX CALL to update the value in the database*/
});

Using the onclick method isn't the best .Check link for more..

Regarding updating the counter, you can simply have an AJAX call that updates the value in the data base.This will also help you write better error or success messages with the .then syntax.

Naisa purushotham · Answer 3 · 2016-04-13T08:58:46.083

0

$(".btnbuy").on("click",function(){

  window.open("<?= $link?>", "_blank")
  $.ajax({
  
  url:'somephpfile.php'
  success:function(data){
  alert(data)
  }
   
  
  });


})

In somephpfile.php

$sql=mysql_query("INSERT INTO stats (id,isclicked) VALUES ("",'true');
echo "success";

edited Apr 13 '16 at 08:58

answered Apr 13 '16 at 07:18

Naisa purushotham

905
10
18

for this you need to include jquery library – Naisa purushotham Apr 13 '16 at 07:19

score 0 · Answer 4 · answered Apr 13 '16 at 07:19

0

Use google analytics and add it as a new dimension.
This way you will be able to track it far better than just a number.

answered Apr 13 '16 at 07:19

Andreas

23,610
6
30
62

Actually, I am using google analytics for my page. However, I am trying to do my own analytics with basic graphs to add these graps into my CRM for Boss:) Just to make her understand better. – kazata Apr 13 '16 at 07:28
@kazata then teach your boss how to use google analytics ;-) ///// ok, I see your point – Andreas Apr 13 '16 at 09:33

pguetschow · Answer 5 · 2016-04-13T07:26:21.017

0

I'd recommend usning jQuery

Remove the href-line, so you only have your <button> defined

Next, include the jQuery lib

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.12.0/jquery.min.js"></script>

in your <head>

Then write a function like this:

$(".btnbuy").on('click',function(){
   window.open("$link", "_blank")){
     $isclicked = true;
    }
  });
}

edited Apr 13 '16 at 07:26

answered Apr 13 '16 at 07:20

pguetschow

5,176
6
32
45

Onclick function to open new window and count clicks

5 Answers5