Memory overflow

Question

  List<int> pal=new List<int>();
        List<int> nums = new List<int>();
        var thdigit1 = 1;
        var thdigit2 = 999;
        while (thdigit2>=1)
        {
            var holder=thdigit1* thdigit2;
            nums.Add(holder);
            thdigit2 -= 1;
            if (thdigit2==0)
            {
                thdigit2 = 999;
                thdigit1 += 1;
            }
        }

I am getting a memory overload problem for too much in the list. Is there a certain limit that my computor can handle? Thanks

Since your computer is probably no infinite machine: yes there definitly is a certain limit. But there maybe a problem in your code. See Ian's answer. — René Vogt, Apr 13 '16 at 14:48
along with referring to below answer kindly read http://stackoverflow.com/help/how-to-ask — kudlatiger, Apr 13 '16 at 14:51
So i belive for this problem the list should contain 999^2 ints in the list, is that too many? — Kieran, Apr 13 '16 at 14:53
Please do not come up with custom description of errors - provide error *exactly* as reported by compiler/runtime. — Alexei Levenkov, Apr 13 '16 at 14:54
http://stackoverflow.com/questions/2009217/whats-the-max-items-in-a-listt — Alexei Levenkov, Apr 13 '16 at 14:56

Ian · Accepted Answer · 2016-04-13T14:50:34.797

2

The problem is when thdigit2 is 1, it is still continuing the while loop,

while (thdigit2>=1)

reduced by 1 and then becomes 0

thdigit2 -= 1;

and... reseted back to 999.

if (thdigit2==0)
{
    thdigit2 = 999;
    thdigit1 += 1;
}

Thus you get memory overflow as you never gets out of the while loop.

To fix it, you probably need to add another termination condition in your while loop:

while(thdigit2 >= 1 && thdigit1 <= 10) //example

edited Apr 13 '16 at 14:50

answered Apr 13 '16 at 14:48

Ian

30,182
19
69
107

The purpose of the code was to create all possible combinations of two three digit numbers. – Kieran Apr 13 '16 at 14:52
I am really stupid, thanks for the answer. First time asking a question and was inexperienced. – Kieran Apr 13 '16 at 15:07
@Kieran no problem. :) everybody must start somewhere.. – Ian Apr 13 '16 at 15:08

Memory overflow

1 Answers1