BindParam Foreach Loop not working

Asked Apr 13 '16 at 16:33

Active Apr 13 '16 at 16:33

Viewed 178 times

This is not working for some reason, same loop works fine with a SELECT statement but not an INSERT statement.

 $sql = "INSERT INTO users(user_id,password) VALUES(?,?)";
 $data = array();
 $data[1] = "1";
 $data[2] = "password";
 public function insert($sql,$data){
    $newQuery = $this->db->prepare($sql);
    //pass $value as a reference to the array item
    foreach ($data as $key => &$value) {  
    // bind the variable to the statement
        $newQuery->bindParam($key,$value); 
    } 
    $newQuery->execute();
}

asked Apr 13 '16 at 16:33

Jerin Oommen

what does your php error log tell you ? – Martin Apr 13 '16 at 16:39
http://stackoverflow.com/questions/12344741/binding-multiple-values-in-pdo – Martin Apr 13 '16 at 16:40
imo, just use 'bindValue' with PDO unless you really need bindParam (BLOB)? – Ryan Vincent Apr 13 '16 at 16:41
@RyanVincent yeah, on consideration you are correct. I was taking the `?` as MySQL- only placeholders. (Partly as I see most of the whole point of PDO being that it uses *named* placeholders) – Martin Apr 13 '16 at 16:56
@martin, I agree with you that using named placeholders makes a lot of sense. Especially if the query is changed and, say, new placeholders can just be added at the end of the list. – Ryan Vincent Apr 13 '16 at 17:04
Thank you guys, I'm going to try that. – Jerin Oommen Apr 13 '16 at 17:33
Hi Guys, that didn't work! Any other solution? – Jerin Oommen Apr 13 '16 at 18:22
For some reason i'm not getting any error! – Jerin Oommen Apr 13 '16 at 18:55
You set PDO to create exceptions on error? see: http://stackoverflow.com/questions/8992795/set-pdo-to-throw-exceptions-by-default. – Ryan Vincent Apr 13 '16 at 19:02
imo: lose the `foreach loop` completely as it adds nothing useful. Change the `$newQuery->execute();` to `$newQuery->execute($data);`. And ensure the $data array has `user_id` as the first element. – Ryan Vincent Apr 13 '16 at 19:11
@RyanVincent That worked, Thank You! – Jerin Oommen Apr 13 '16 at 22:36

BindParam Foreach Loop not working

0 Answers0