All cases in switch executes while only one is supposed to be executed

Question

I am trying to create a very simple game in which several players of different types tries to guess a number in a range. I made a function to initialize an array of players, and I used switch-case to do it.

For some reason, if I put a number, it goes over all the cases after it, even if there are not enough cells in the array. For example, when entered 2, the value for type HUMAN, it did also the cases for 3 and 4- and players of types COMPUTER and GUMBLER are created.

Here is the code:

    String name;
    int count = 0;
    System.out.println("How many players will participate?");
    players = new Player[reader.nextByte()];
    for (Player player: players)
    {    
        count++;
        System.out.print("\n1)Name of the player: ");
        name = reader.next();
        System.out.println("What will be its type? WRITE A NUMBER\n1- Monley\n2-Human\n3-Gumbler\n4-Computer");
        switch (reader.nextInt())
        {
            case 1:
                player = new Monkey (name, MAXIMUM, MINIMUM);
                System.out.println("A moneky was created");
            case 2:
                player = new Human (name);
                System.out.println("A human was created");
            case 3:
                player = new Gumbler (name, MAXIMUM, MINIMUM);
                System.out.println("A gummbler was created");
            case 4:
                player = new Computer (name, MAXIMUM, MINIMUM);
                System.out.println("A computer was created");
        }
    }

MAXIMUM and MINIMUM are the minimal and maximal numbers the number needs to be guessed can be. Human, Monkey, Computer and Gumbler are classes extending the absract class Player. players is the array of players (of type Player).

I suggest you read the Java tutorials on the Oracle web site. Here is an example https://docs.oracle.com/javase/tutorial/java/nutsandbolts/switch.html — Peter Lawrey, Apr 17 '16 at 14:56

score 5 · Accepted Answer · answered Apr 17 '16 at 14:53

5

End your each case block with a break.

answered Apr 17 '16 at 14:53

Raman Shrivastava

2,923
15
26

The best solution for this kind of problem is to mark is as duplicate. – The Roy Apr 17 '16 at 15:49

score 2 · Answer 2 · answered Apr 17 '16 at 14:55

You will need a break statement in each case. See switch in java tutorial

    String name;
    int count = 0;
    System.out.println("How many players will participate?");
    players = new Player[reader.nextByte()];
    for (Player player: players)
    {    
        count++;
        System.out.print("\n1)Name of the player: ");
        name = reader.next();
        System.out.println("What will be its type? WRITE A NUMBER\n1- Monley\n2-Human\n3-Gumbler\n4-Computer");
        switch (reader.nextInt())
        {
            case 1:
                player = new Monkey (name, MAXIMUM, MINIMUM);
                System.out.println("A moneky was created");
                break; 
            case 2:
                player = new Human (name);
                System.out.println("A human was created");
                break;
            case 3:
                player = new Gumbler (name, MAXIMUM, MINIMUM);
                System.out.println("A gummbler was created");
                break;
            case 4:
                player = new Computer (name, MAXIMUM, MINIMUM);
                System.out.println("A computer was created");
        }
    }

All cases in switch executes while only one is supposed to be executed

2 Answers2