calling a controller from another in AngularJS

Question

I have a controller like this :

  .controller('candidatureStartCtrl', function ($scope, $parse, fileUploadCtrl) {

//...code
      fileUploadCtrl.uploadFile($scope.identityDocUpload);
//...code
}

in candidatureStartCtrl I'm calling another controller which is fileUploadCtrl to use its function uploadFile().

but I get this error in console even though I imported the fileUploadCtrl js in the index.html :

 Error: [$injector:unpr] Unknown provider: fileUploadCtrlProvider <- fileUploadCtrl <- CandidatureStartCtrl

this is a fiddle with the same concept :

http://jsfiddle.net/7tzXh/143/

How can I solve this ?

According to the error your fileUploadCtrl is undefined. Make sure you've added proper reference — Shreyas, Apr 20 '16 at 10:25
@Shreyas as I said I've imported the `fileUploadCtrl` js in the index.html — Renaud is Not Bill Gates, Apr 20 '16 at 10:26
@Shreyas yes it is, I think its due to injection or something like this since I need to use $inject in that case but I dont know how, I'm still learning angularjs — Renaud is Not Bill Gates, Apr 20 '16 at 10:34
[Injecting controller in another controller](http://stackoverflow.com/questions/25417162/how-do-i-inject-a-controller-into-another-controller-in-angularjs). Injecting controller in another controller is not the best way to call a function. Maybe create a service or use some other mechanics like $scope.$broadcast(). — k4l4m, Apr 20 '16 at 10:45

score 1 · Accepted Answer · answered Apr 20 '16 at 11:03

1

You cannot inject controllers directly without using $controller as mentioned in one of the comments to the question. If you need to share data, you can use factory or service.

Please find the working fiddle here:

http://jsfiddle.net/7tzXh/144/

answered Apr 20 '16 at 11:03

Adarsh Konchady

2,577
5
30
50

Thanks I actually used that solution before and I wanted to ask if I can to use a controller inside another but since controllers get garbage collected on route changes using a service/factory is the best idea. – Renaud is Not Bill Gates Apr 20 '16 at 11:25

score 0 · Answer 2 · answered Apr 20 '16 at 11:16

0

$controller is used to inject a controller into another. I've created a simple fiddle to make it clear.

answered Apr 20 '16 at 11:16

Shreyas

1,927
17
34

calling a controller from another in AngularJS

2 Answers2