long declared in class but constructor seems to wait for int

Question

I have the following class in Java:

class Adresse4 {
    private String strasse;
    private String hausnummer;
    private int postleitzahl;
    private String ort;
    private long telefon;

    Adresse4(String strasse, String hausnummer, int postleitzahl, String ort, long telefon) {
        this.strasse = strasse;
        this.hausnummer = hausnummer;
        this.postleitzahl = postleitzahl;
        this.ort = ort;
        this.telefon = telefon;
    }
    Adresse4(Adresse4 ad) {
        this.strasse = ad.strasse;
        this.hausnummer = ad.hausnummer;
        this.postleitzahl = ad.postleitzahl;
        this.ort = ad.ort;
        this.telefon = ad.telefon;
    }
}

and creating an object from this class like this:

Adresse4 adTest = new Adresse4("Lothstraße", "22", 80999, Ort.Berlin, 09909999);

My IDE tells me that the integer number is too large where I have declared a long.

How can I fix this?

Possible duplicate of [Integer with leading zeroes](http://stackoverflow.com/questions/565634/integer-with-leading-zeroes) — Savior, Apr 20 '16 at 17:52
Well, because `09909999` is too big for either `int` or `long`. — Savior, Apr 20 '16 at 17:56
A phone number is better represented as a `String`, not a numeric value. — Savior, Apr 20 '16 at 17:56
@Pillar, or one step further, a phone number might be best represented by a class; I dislike domain modeling using String objects. — KevinO, Apr 20 '16 at 18:01

score 1 · Answer 1 · answered Apr 20 '16 at 19:01

Numbers which start with a 0 are in octal. e.g. 012 is 10 in decimal.

The number 09 isn't valid because 9 is not an octal digit.

In short, phone numbers are not integers and they usually include formatting such as leading 0's or + for international. You are better off storing it as a String or a PhoneNumber type which wraps a String.

e.g. my phone number starts +44 75... and the + would be discarded as an integer.

long declared in class but constructor seems to wait for int

1 Answers1