What is wrong with my sql formatting

Question

$sql = 'INSERT INTO `a1343640_test`.`Orders`
 (`TicketId`, `Id`, `MenuItemName`, `Price`, `Quantity`, `Student ID`, `Student Year`, `Student Name`, `Student Email`)
  VALUES ('$ticketID', '$orderID ', '$menu', '$price', '$quantity', '$studID', '$StudYr', '$StudName', '$StudEmail');';

Is what I have, however I’ve got a problem with the values which I am unsure what I have done wrong. If someone can assist me that would be great.

See how to concatenate strings: http://stackoverflow.com/q/8336858/3933332 But remember that you should enclose your strings in quotes for the query. — Rizier123, Apr 22 '16 at 06:38
$sql = "INSERT INTO `a1343640_test`.`Orders` (`TicketId`, `Id`, `MenuItemName`, `Price`, `Quantity`, `Student ID`, `Student Year`, `Student Name`, `Student Email`) VALUES ('$ticketID', '$orderID ', '$menu', '$price', '$quantity', '$studID', '$StudYr', '$StudName', '$StudEmail')"; — RJParikh, Apr 22 '16 at 06:40
$StudName contains string so in your case query gives error without quotes. @Anant — RJParikh, Apr 22 '16 at 06:45

score 0 · Answer 1 · answered Apr 22 '16 at 06:40

Update your query:

$sql = 'INSERT INTO `a1343640_test`.`Orders`
 (`TicketId`, `Id`, `MenuItemName`, `Price`, `Quantity`, `Student ID`, `Student Year`, `Student Name`, `Student Email`)
  VALUES ("'.$ticketID.'", "'.$orderID.'", "'.$menu.'", "'.$price.'", "'.$quantity.'", "'.$studID.'", "'.$StudYr.'", "'.$StudName.'", "'.$StudEmail.'");';

score 0 · Accepted Answer · answered Apr 22 '16 at 06:42

You are using quotes in wrong way, try this

$sql = 'INSERT INTO `a1343640_test`.`Orders`
 (`TicketId`, `Id`, `MenuItemName`, `Price`, `Quantity`, `Student ID`, `Student Year`, `Student Name`, `Student Email`)
  VALUES ("'.$ticketID.'", "'.$orderID.'", "'.$menu.'", "'.$price.'", "'.$quantity.'", "'.$studID.'", "'.$StudYr.'", "'.$StudName.'", "'.$StudEmail.'");';

or another way is

$sql = "INSERT INTO a1343640_test.Orders (TicketId, Id, MenuItemName, Price, Quantity, Student ID, Student Year, Student Name, Student Email) VALUES ('$ticketID', '$orderID ', '$menu', '$price', '$quantity', '$studID', '$StudYr', '$StudName', '$StudEmail')";

What is wrong with my sql formatting

2 Answers2