C# INSERT INTO isn`t working (web sql)

Question

I looked in the forum a lot and researched for my problem but I couldn`t find something that helped me. I have tried a lot of suggestions from here. I have a site and 3 sign up pages. every page have some information, validators are already set up and I built an SQL Server (Microsoft visual studio community 2015). Here is the code of the first sign up page:

EDIT The problem was that Table is a reserved word, I just had to write [Table] instead of Table in the sqlCommand

Any help will be estimated.

You should not be connecting directly to an mdf file. You may not have credentials and you may be writing to the wrong database. Use the database name in the SQL Server. The server already knows the file name when it was attached. You connection string just needs the name of the server. You can add a 'USE database_name' statement to select the correct database (you may have more than one database in the server). — jdweng, Apr 23 '16 at 15:52

score 5 · Accepted Answer · edited May 23 '17 at 11:45

5

You need to add quotes around your parameters when assigning a value:

sqlCommand.Parameters["@email"].Value = email;
sqlCommand.Parameters["@username"].Value = userName;

The reason why you need quotes is because in your case @email and email refers to the same string variable. You can read more about @ symbol in C# in answers to What's the use/meaning of the @ character in variable names in C#?

I'm not 100% sure it code above works or not, if not - you then you should use method Add or AddWithValue. Regardless of the method you should use "@email" instead of @email.

For recommendation why to use Add in favor of AddWithValue please refer to this article.

EDIT: It seems the issue is different. In your code you assign email and username to null:

string email = null, userName = null;

Then nowhere in the code you change these values, i.e. they still remain null. Then when you get to this line:

if (email != null && userName != null)

your values are still null, and the logic inside if statement is never executed. Fix this part of the code first, and then my initial answer will become helpful as well.

UPDATE 2 SQL Parameters collection does not contain the parameters, so it needs to be performed using Add method:

sqlCommand.Parameters.Add("@email", SqlDbType.VarChar, 50).Value = email;
sqlCommand.Parameters.Add("@userName", SqlDbType.VarChar, 12).Value = userName;

edited May 23 '17 at 11:45

Community

1
1

answered Apr 23 '16 at 15:40

dotnetom

24,551
9
51
54

Thank you, I will try it – D4NieLDev Apr 23 '16 at 16:28
still not working... I think I have a problem in my SQL script, I will attach it to the question – D4NieLDev Apr 23 '16 at 16:33
@D4NieLDev I updated the answer above. It seems your `if` statement is never executed – dotnetom Apr 23 '16 at 16:44
I have assigned them to null in the beginning but I have required field validators for both variables. – D4NieLDev Apr 23 '16 at 16:53
@D4NieLDev The only place where you assign a value to `email` is after you perform `Response.Redirect`. So you redirect a user to a different page and SQL statement is not executed once again – dotnetom Apr 23 '16 at 16:57
OK I will try another option without this if – D4NieLDev Apr 23 '16 at 16:58
I have tried your solution the new code is above in the question, but I am now getting this error: Exception Details: System.IndexOutOfRangeException: An SqlParameter with ParameterName '@email' is not contained by this SqlParameterCollection. – D4NieLDev Apr 23 '16 at 17:02
OK I understood you, look at my new code I have updated it – D4NieLDev Apr 23 '16 at 17:15
@D4NieLDev Look at the Update 2 from the answer. Make sure to use method `Add` – dotnetom Apr 23 '16 at 17:16
OK I'll try it. thanks for the help you are really useful – D4NieLDev Apr 23 '16 at 17:17
Now I have another problem: **Incorrect syntax near the keyword 'Table'.** On the row: **sqlCommand.ExecuteNonQuery();** – D4NieLDev Apr 23 '16 at 17:26
@D4NieLDev Table is reserved keyword, try using `INSERT INTO [Table] ...` instead – dotnetom Apr 23 '16 at 18:21

C# INSERT INTO isn`t working (web sql)

1 Answers1