getting error - Unexpected "if" keyword after "@" character. Once inside code, you do not need to prefix constructs like "if" with

Question

im getting error in view- ""test1.cshtml"

Unexpected "if" keyword after "@" character. Once inside code, you do not need to prefix constructs like "if" with

test1.cshtml

    @model WebApplication9.Models.Names


@using (Html.BeginForm())
{
    @Html.TextBoxFor(m => m.MyName)

    <button type="submit">Submit</button>

    if (!string.IsNullOrWhiteSpace(Model.MyName))
    {
        <p>welcome, your name is @Model.MyName</p>
    }
}

controller code

 public ActionResult test1()
        {

            Names name = new Names();

            return View(name);

            ViewBag.Message = "Your contact page.";

            return View();
        }
        [HttpPost]
        public ActionResult test1(string name)
        {
            ViewBag.Message = "Hello what is ur name ???";
            ViewBag.Name = name;
            return View();
        }

model code

namespace WebApplication9.Models
{
    public class Names
    {
        public string MyName { get; set; }
    }
}

Did you try reading and understanding the error? Did you try doing some research after that? — CodeCaster, Apr 29 '16 at 13:29
Your research doesn't show from your question. Anyway, then don't run to Stack Overflow at the first error you get, but find a decent tutorial. — CodeCaster, Apr 29 '16 at 13:31
@STACK2 You haven't done enough research. You can never do enough research. — Brendan Vogt, Apr 29 '16 at 13:45
getting error because . ViewBag.Name = name;in this line .name dont have data. its getting null — STACK2, Apr 29 '16 at 13:52

score 14 · Accepted Answer · edited Apr 29 '16 at 14:14

14

Try:

@model WebApplication9.Models.Names


@using (Html.BeginForm())
{
    @Html.TextBoxFor(m => m.Name)

    <button type="submit">Submit</button>

    if (!string.IsNullOrWhiteSpace(Model.MyName))
    {
        <p>welcome, your name is @Model.MyName</p>
    }
}

Since you have the @using, the Razor code inside it does not need the @. But, if you have an HTML element, then you will need to use the @, like on the Welcome text.

edited Apr 29 '16 at 14:14

CodeCaster

147,647
23
218
272

answered Apr 29 '16 at 13:34

Denis V

421
4
17

that error solved but i got one more error , if (!string.IsNullOrWhiteSpace(Model.MyName)) Object reference not set to an instance of an object. – STACK2 Apr 29 '16 at 13:39
@STACK2 You have 2 properties defined, `Name` and `MyName`. One of the two don't exist. Decide on which one you want to use and stick with it. – Brendan Vogt Apr 29 '16 at 13:41
If it solved your primary problem that is described on question title, accept the answer plz. – Denis V Apr 29 '16 at 13:49
"Try" is not an answer. Explain what you changed. – CodeCaster Apr 29 '16 at 14:11

score 1 · Answer 2 · edited Jul 28 '23 at 17:46

1

There's no need to add @ sign in front of "if". The code should be like this:

@model WebApplication9.Models.Names
@using (Html.BeginForm())
{
      Html.TextBoxFor(m => m.Name)
      <button type="submit">Submit</button>
     if (!string.IsNullOrWhiteSpace(Model.MyName))
     {
        <p>welcome, your name is @Model.MyName</p>
     }
}

edited Jul 28 '23 at 17:46

Uğur Demirel

71
1
2
9

answered Apr 29 '16 at 13:36

Auguste

2,007
2
17
25

Brendan Vogt · Answer 3 · 2016-04-29T13:54:57.063

0

You have to remove the @ symbol in front of your if statement.

This is how it should look:

@using (Html.BeginForm())
{
    @Html.TextBoxFor(m => m.MyName)

    <button type="submit">Submit</button>

    if (!string.IsNullOrWhiteSpace(Model.MyName))
    {
        <p>welcome, your name is @Model.MyName</p>
    }
}

You code is not consistent here, you are using 2 different property names, namely Name and MyName. Use only one.

You are also not populating the MyName property any where? You are using IsNullOrWhiteSpace on a property that doesn't have a set value. Try this as well:

public ActionResult test1()
{
     Names name = new Names();
     name.MyName = "Clown";

     return View(name);
}

You Index action method has 2 return views, remove one.

Please spend time working through some ASP.NET MVC tutorials. It will take some time learning but in the long run it is for the best.

edited Apr 29 '16 at 13:54

answered Apr 29 '16 at 13:37

Brendan Vogt

25,678
37
146
234

both are i set to MyName still getting error – STACK2 Apr 29 '16 at 13:42
@STACK2 Yes I see that but look further up in the code, you have `m.Name`. They all need to be the same. So either `Name` or `MyName` does not exist in your model. – Brendan Vogt Apr 29 '16 at 13:43
i have changed m.Name to m.MyName. still getting error. kindly go through my post. i provided model and controller – STACK2 Apr 29 '16 at 13:45
It's really simple then. `Name` does not exist. It is not in your model but you are still trying to use it in your view. Change it to this code in your view: `@Html.TextBoxFor(m => m.MyName)` – Brendan Vogt Apr 29 '16 at 13:46
i already changed . still getting error – STACK2 Apr 29 '16 at 13:48
Try setting a value to `MyValue` like I explained in my answer. – Brendan Vogt Apr 29 '16 at 13:56
hey i got it thanks..@Brendan – STACK2 Apr 29 '16 at 13:58
We have answered you initial question ages ago. Accept an answer and move on to the next post. – Brendan Vogt Apr 29 '16 at 14:00

getting error - Unexpected "if" keyword after "@" character. Once inside code, you do not need to prefix constructs like "if" with

3 Answers3