Return value from string function

Question

i have a string array that contains 20 words. I made a function that take 1 random word from the array. But i want to know how can i return that word from array. Right now i am using void function, i had used char type but it wont work. Little help here ? Need to make word guessing game.

CODE:

#include <iostream>
#include <time.h>
#include <cstdlib>
#include <stdlib.h>
#include <algorithm>///lai izmantotu random shuffle funckiju
#include <string>
using namespace std;


void random(string names[]);


int main() {
     char a;
     string names[] = {"vergs", "rokas", "metrs", "zebra", "uguns", "tiesa", "bumba",
                       "kakls", "kalns", "skola", "siers", "svari", "lelle", "cimdi",
                       "saule", "parks", "svece", "diegs", "migla", "virve"};

random(names);

        cout<<"VARDU MINESANAS SPELE"<<endl;
        cin>>a;







return 0;
}

void random(string names[]){
    int randNum;
for (int i = 0; i < 20; i++) { /// makes this program iterate 20 times; giving you 20 random names.
srand( time(NULL) ); /// seed for the random number generator.
randNum = rand() % 20 + 1; /// gets a random number between 1, and 20.
names[i] = names[randNum];
}
//for (int i = 0; i < 1; i++) {
//cout << names[i] << endl; /// outputs one name.
//}

}

I don't see how the code you posted relates to what you ask (which isn't all that clear, TBH). — StoryTeller - Unslander Monica, May 01 '16 at 14:48
Either use a `vector` or tell the function how many elements are in the array. Don't hard-code 20 into the function. That's tangential to your question, but relevant general advice. Make sure that functions know how big an array they're dealing with. — Jonathan Leffler, May 01 '16 at 14:48
What about returning a string? `std::string random(std::string names[]);` — Galik, May 01 '16 at 14:49
See [`srand()` — Why call it only once?](http://stackoverflow.com/questions/7343833/srand-why-call-it-only-once/) for details on why your use of `srand()` is thoroughly misguided. — Jonathan Leffler, May 01 '16 at 14:49
Also never seed a random number generator in a loop, seed it *once* at the start of the program. — Galik, May 01 '16 at 14:50

Greg M · Accepted Answer · 2016-05-01T14:55:16.817

Make random return string. You also only need to seed the number generator once. Since you only want to get 1 random word from the array, you don't need a for loop.

string random(string names[]){
    int randNum = 0;
    randNum = rand() % 20 + 1;
    return names[randNum];
}

Then, in the main function, assign a string variable to the return value of the random function.

int main() {
    srand( time(NULL) ); // seed number generator once
    char a;
    string names[] = {"vergs", "rokas", "metrs", "zebra", "uguns", "tiesa", "bumba",
                       "kakls", "kalns", "skola", "siers", "svari", "lelle", "cimdi",
                       "saule", "parks", "svece", "diegs", "migla", "virve"};

    string randomWord = random(names);

    cout<<"VARDU MINESANAS SPELE"<<endl;
    cin>>a;

    return 0;
}

score 2 · Answer 2 · answered May 01 '16 at 15:00

In your question as well as in the previous answer, you are running out of bounds accessing the names array:

int randNum = rand() % 20 + 1;
return names[randNum];

You are never accessing names[0] but instead reach behind the array when addressing names[20].

score 1 · Answer 3 · answered May 01 '16 at 14:58

1

Additionally srand(time(NULL)) should be called only one time, on the beginning of main() function.

answered May 01 '16 at 14:58

Lucas535

26
3

And you should not use `srand()` in modern code. Instead look to ``. – Jesper Juhl May 01 '16 at 15:10

score 0 · Answer 4 · answered May 01 '16 at 14:50

0

I'm not super familiar with strings, but you should be able to just declare random() as a string function.

Ex: string random (string names[]);

answered May 01 '16 at 14:50

Eric

79
1
3

Return value from string function

4 Answers4