Recieveing error "Trying to get property of non-object"

Question

When I go on my edit view recieve this error "Trying to get property of non-object". I have an edit view for editing questionnaires, and in that view I can add questions.

my edit view:

@extends('layouts.master')

@section('title', 'Edit Questionnaire | SurveySays!')

@section('content')
    <div class="col-lg-12 col-md-12 col-sm-12 col-xs-12">
        <h1>Edit {{$questionnaires->title}}</h1>
        <h3>Edit your questionnaire using the form below:</h3>

        {!! Form::model($questionnaires, ['method' => 'PATCH', 'url' => '/questionnaires/' . $questionnaires->id]) !!}

        <div class="container-fluid">
            <div class="form-group">
                {!! Form::label('title', 'Title:') !!}
                {!! Form::text('title',null,['id' => 'title','class' => 'form-control']) !!}
            </div>
            <div class="form-group">
                {!! Form::label('description', 'Description:') !!}
                {!! Form::textarea('description',null,['class' => 'form-control']) !!}
            </div>
            <div class="form-group">
                {!! Form::label('ethics', 'Ethical considerations:') !!}
                {!! Form::textarea('ethics',null,['class' => 'form-control']) !!}
            </div>
            <hr>
            <div class="form-group">
                {!! Form::label('questions', 'Questions:') !!}
                @foreach($questions as $question)
                    <div class="form-group">
                        {!! Form::checkbox('question[]', $question->id, $questionnaires->question->contains($question->id), ['id' =>$question->id]) !!}}
                        {!! Form::label($question->question) !!}
                    </div>
                @endforeach
            </div>
            <hr>
            <div class="form-group">
                {!! Form::submit('Update', array('class' => 'btn btn-success form-control')) !!}
            </div>
        </div>
    </div>

    {!! Form::close() !!}


@endsection

My QuestionnairesController@edit function:

public function edit($id)
    {
        $questionnaires = Questionnaire::findOrFail($id);
        $questions = Question::findOrFail($id);

        return view('questionnaires.edit', compact('questionnaires'), compact('questions'));
    }

What is causing this error? Please help! :)

What line is the error occurring on? It highly likely that either `$questionnaires` or `$question` is not an object. — Scuzzy, May 05 '16 at 22:49
share the full error can you pls? ++ try dd($questionnaires($id)); and dd($questions($id)); and check if the result is not null — Achraf Khouadja, May 06 '16 at 00:23

score 0 · Answer 1 · answered May 06 '16 at 01:57

0

I think maybe you just forgot to set relation in Questionnaire Model or Questionnaire just can't find relation question in $questionnaires->question.

Make sure it. and hope that can help you .

answered May 06 '16 at 01:57

曉月桐生

11
2

score 0 · Answer 2 · answered May 06 '16 at 04:24

0

Try below code in your controller

public function edit($id)
{
    $questionnaires = Questionnaire::findOrFail($id);
    $questions = Question::findOrFail($id);

    return view('questionnaires.edit', compact('questionnaires','questions'));
}

answered May 06 '16 at 04:24

krunal nerikar

436
4
12

score 0 · Answer 3 · answered May 06 '16 at 05:12

findOrFail will return an instance of the Model, not a Collection of Models. In your controller, you have:

$questions = Question::findOrFail($id);

With this code, $questions will be a Question instance (or null). Then, in your view, you're looping over this variable with a foreach:

@foreach($questions as $question)
    // snip
@endforeach

This will end up just looping over the attributes on the instance. The first attribute that it hits that is not itself an object will give you the "Trying to get property of non-object" error.

From your code, I'm assuming that $questions is supposed to be a list of all the questions. I'm guessing your code in your controller should actually be:

$questions = Question::get();

Recieveing error "Trying to get property of non-object"

3 Answers3