token illegal; PHP inside JavaScript code

Question

I use php in my JavaScript code to print a JavaScript line but I have an error. what am I doing wrong?

<?php  
    if (isset($_GET['dateSelected'])) {
        echo '$("#eliminarCitaBtn").attr("href", "index.php/agenda/eliminarCita/"+event.cita_id+"/?agendaId='.$_GET["agendaId"].'&dateSelected='.$_GET["dateSelected"].');';
    } else {
        echo "$('#eliminarCitaBtn').attr('href', 'index.php/agenda/eliminarCita/'+event.cita_id+'/?agendaId=".$_GET['agendaId'].");";
    }
?>

You should probably `urlencode()` at the very least but also verify the input for security reasons. That is easily injectable with malicious XXS script. — Rasclatt, May 06 '16 at 23:30

score 0 · Accepted Answer · answered May 06 '16 at 23:38

0

You are't closing the quotes at the end of either attr().

There '");'; and there "');";

answered May 06 '16 at 23:38

Gabriel

2,170
1
17
20

brother have reason had not closed the quotes of attr('') thanks – Nov Esk Eduard May 06 '16 at 23:51

token illegal; PHP inside JavaScript code

1 Answers1