Need enlightment about NPath complexity

Question

I added PMD to my Eclipse workspace and I'm working on cleaning the code.

My most complex method says it has a NPath complexity of 804, ok no problem, it probably need refactoring.

But then I've something that look rather simple that has a NPath complexity of 3125, that seems just wrong :

public void toUpperParams() {
    valueParam1 = StringUtils.isNotEmpty(valueParam1) ? valueParam1.toUpperCase() : null;
    valueParam2 = StringUtils.isNotEmpty(valueParam2) ? valueParam2.toUpperCase() : null;
    valueParam3 = StringUtils.isNotEmpty(valueParam3) ? valueParam3.toUpperCase() : null;
    valueParam4 = StringUtils.isNotEmpty(valueParam4) ? valueParam4.toUpperCase() : null;
    valueParam5 = StringUtils.isNotEmpty(valueParam5) ? valueParam5.toUpperCase() : null;
}

Am I missing something ?

score 1 · Accepted Answer · edited May 23 '17 at 12:31

1

It seems that ternary increases the NPath factor. Below two explanations I could find:

Question on Guthub

Question on stackoverflow

edited May 23 '17 at 12:31

Community

1
1

answered May 13 '16 at 10:07

Tom

1,387
3
19
30

Thank you. Still sound weird, if anyone know why this decision was taken I'm eager to hear it. – TheBakker May 13 '16 at 12:44

score 0 · Answer 2 · answered May 13 '16 at 14:47

0

I don't think you miss anything. According to my calculation, NPath should be 10 based on the definition, which was given in the following article: NPath complexity

answered May 13 '16 at 14:47

Csuki

1,297
8
21

I tried it out with SourceMeter, and it gave 11 for NPath complexity for this method. – Csuki May 13 '16 at 15:02

Need enlightment about NPath complexity

2 Answers2