parse query param by JavaScript

Question

I have a function in js which parse a url and creates a map of (paramName,value)

The code is like:

var search = location.search.substring(1);
var data = {}
if(search!="")
{
    var urlParams = JSON.parse('{"' + decodeURI(search).replace(/"/g, '\\"').replace(/&/g, '","').replace(/=/g, '":"') + '"}');
    for (var key in urlParams) {
        data[key] = urlParams[key];
    }
}

Now this is working fine for a plain url like www.google.com?param1=2&param4=hello

But it is not working for a encrypted url like www.google.com?param1=XDTY-300Hbc=&param4=hello

as here the param1=XDTY-300Hbc= contains a = in the end. Please help

Just a side not you don't need to iterate over urlParams you can just use `data = JSON.parse(...` — jcubic, May 13 '16 at 14:41

jcubic · Accepted Answer · 2017-08-30T17:05:03.413

1

Try this:

var url = 'www.google.com?param1=XDTY-300Hbc=&param4=hello';
var query = url.substring(1);
var data = {};
query.split('&').filter(Boolean).forEach(function(pair) {
  pair = pair.split('=');
  data[decodeURIComponent(pair[0])] = decodeURIComponent(pair.slice(1).join('=')).replace(/\+/g, ' ');
});
document.body.innerHTML = JSON.stringify(data);

edited Aug 30 '17 at 17:05

answered May 13 '16 at 14:38

jcubic

61,973
54
229
402

[Your answer has a lot of issues](http://zzzzbov.com/blag/querystring-hell). – zzzzBov May 13 '16 at 14:43
1

Forget about decodeURIComponent – jcubic May 13 '16 at 14:45
1

I would use `var idx = pair.indexOf('=');` and `data[decodeURIComponent(pair.substr(0,idx))] = decodeURIComponent(pair.substr(idx+1));` instead of messing with arrays. – Jonathan Gray May 13 '16 at 14:46
Also if there is no value there will not be an equals sign. In such a case pair will be equal to the key name and the value should be set to null. – Jonathan Gray May 13 '16 at 14:49

parse query param by JavaScript

1 Answers1