Breakpoint in Acces Database Application C#

Question

I get syntax error when i try to run and insert data in my database.... i have a log in button and delete button that works just fine.... but this one does not and i don't get it..... Can some one tell me an alternative to insert or what is the mistake?

public partial class Register : Form
    {
        private OleDbConnection connect = new OleDbConnection();
        public Register()
        {
            InitializeComponent();
            connect.ConnectionString = @"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=resources\Users.accdb;
Persist Security Info=False;";
        }
    private void register1_Click(object sender, EventArgs e)
    {
        try
        {
            connect.Open();
            OleDbCommand command = new OleDbCommand();
            command.Connection = connect;
            command.CommandText ="insert into Users(Username, Password, Email)  values(' " + userR_box.Text + " ',' " + passwordR_box.Text + " ',' " + mailR_box.Text + " ')";
                            if ((userR_box.Text == "") || (passwordR_box.Text == "") || (mailR_box.Text == ""))
            {
                MessageBox.Show("Va rugam completati toate campurile");
            }
            else
            {
                command.ExecuteNonQuery();

            }
        }
        catch (Exception ex)
        {
            MessageBox.Show("Error "+ ex);
        }
        connect.Close();
    }

score 0 · Answer 1 · edited May 23 '17 at 11:52

0

Firstly, read up on adding parameters to your query, on MSDN or Stack Overflow (How do parameterized queries help against SQL injection?).

It will save you building a string and maybe getting quotes in the wrong place.

edited May 23 '17 at 11:52

Community

1
1

answered May 15 '16 at 19:49

Peter Bill

508
3
12

score -1 · Answer 2 · answered May 15 '16 at 21:16

Looking at your code i noticed 3 things:

You have extra space before every value ' " + userR_box.Text + " '
Its not clear what is the data that you are trying to insert, if it contains ' or any other char which might affect the query ... this will cause the error.
Password is reserved keyword, use this INSERT into Users ([Username], [Password], [Email]... to avoid reserved keywords.

Breakpoint in Acces Database Application C#

2 Answers2