dialog - The specified child already has a parent. You must call removeView() on the child's parent first

Question

After a check demanding the user to switch on internet services and I try to click on a button my app crashes with the error message

java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.

On this line it crashes, I have tried doing this but not resolved absolutely

if(alert.getContext() != null){
            alert.show();
        }

This is the complete code

else if (id == R.id.xyz) {

            //startActivity(borrowIntent);
            AlertDialog.Builder alert = new AlertDialog.Builder(MainActivity.this);
            alert.setTitle("xyz");
            input.setFilters(new InputFilter[] {
                    // Maximum 2 characters.
                    new InputFilter.LengthFilter(6),
                    // Digits only.
                    DigitsKeyListener.getInstance(), 
                });
            // Digits only & use numeric soft-keyboard.
            input.setKeyListener(DigitsKeyListener.getInstance());
            input.setHint("xyz");
            alert.setView(input);
            alert.setPositiveButton("Borrow", new DialogInterface.OnClickListener() {
            public void onClick(DialogInterface dialog, int whichButton) {
                if(input.getText().length() == 0)
                {
                    input.setError("xyz is required !");
                }
                else
                {

                   if(isNetworkAvailable())
                      {
                         xyz( input.getText().toString());

                      }else{

                            //setContentView(R.layout.main);

                            AlertDialog.Builder builder = new AlertDialog.Builder(
                                    MainActivity.this);
                              builder.setCancelable(false);
                              builder.setTitle("xyz");
                              builder.setMessage("Please enable wifi services");
                              builder.setInverseBackgroundForced(true);
                              builder.setPositiveButton("Ok",
                                      new DialogInterface.OnClickListener() {
                                          @Override
                                          public void onClick(DialogInterface dialog,
                                                  int which) {

                                              startActivityForResult(new Intent(android.provider.Settings.ACTION_SETTINGS), 0);
                                              dialog.dismiss();


                                          }
                                      });
                              AlertDialog alerts = builder.create();
                              alerts.show();
                           }//end of block

                        }
              }
            });
            alert.setNegativeButton("Cancel", new DialogInterface.OnClickListener() {
              public void onClick(DialogInterface dialog, int whichButton) {
                // Canceled.
              }
            });
            if(alert.getContext() != null){
            alert.show(); //crashes at this line
            }
        }

Please what am I missing?

Can you paste activity or fragment code in which you are using that dialog — mdDroid, May 26 '16 at 09:12

score 24 · Accepted Answer · answered May 26 '16 at 09:12

24

The problem is on this line: alert.setView(input); You added input View that have already parent. Create new input instance.

answered May 26 '16 at 09:12

dieter_h

2,707
1
13
19

1

I need only an input instance of type Edittext declared at class level – Blaze May 26 '16 at 09:23
[Generating EditText programatically](http://stackoverflow.com/questions/12985825/generating-edit-text-programatically-in-android) – dieter_h May 26 '16 at 09:29
but you have to place a check if the view is null or not null – Blaze May 26 '16 at 10:27

score 18 · Answer 2 · answered May 07 '18 at 23:00

18

according to this post, add this check to remove input from it's parent and readd it:

if(input.getParent()!=null)
        ((ViewGroup)input.getParent()).removeView(input); // <- fix
    alert.addView(input);

answered May 07 '18 at 23:00

Xianwei

2,381
2
22
26

mdDroid · Answer 3 · 2016-05-26T09:37:57.743

3

Put following line

 final AlertDialog alertd = alert.create();

After

 AlertDialog.Builder alert = new AlertDialog.Builder(MainActivity.this);

edited May 26 '16 at 09:37

answered May 26 '16 at 09:14

mdDroid

3,135
2
22
34

the input is actually a textfield. so on removing the user will have field to input data – Blaze May 26 '16 at 09:23
Dialog is in fragment or in activity – mdDroid May 26 '16 at 09:24
input is a reference to Edittext – Blaze May 26 '16 at 09:26
I have to modify my code. Because I cant find the code – Blaze May 26 '16 at 09:39
So where will I now use this handle alerd – Blaze May 26 '16 at 09:41

Emad Easa · Answer 4 · 2023-04-03T02:39:14.130

Following situation can also happen (happened to me):

Sometimes when you use a listview you initialize it with an adapter, which belongs to a certain layout. Now lets say the root view of this layout file is a <LinearLayout> with the id "root_view".

If you register now for a context menu in your activity and create an AlerdDialog.Builder which appears after choosing a certain menu element and initialize it with a layout file, which also has a root element with an id called "root_view" where all elements which belong to your AlertDialog are children of it, then those elements "will not be found". You will not be able to access those elements with findViewById, instead you can only access the elements from the <LinearLayout> of your list view and you get the same error message at the line where you call builder.show() (or in the case here alert.show()).

So generally it is a good idea to name the ids of your elements in the layout files uniquely, for your project.

score 0 · Answer 5 · edited Nov 29 '21 at 17:59

0

I forgot to call create() on the AlertDialog.Builder. When you call show() without calling the create() method, the AlertDialog instance gets created. This worked the first time but then subsequent clicks got the IllegalStateException. As I was calling show() inside of my onClickListener, it was going to create a new AlertDialog instance every time button was clicked.

edited Nov 29 '21 at 17:59

Tomerikoo

18,379
16
47
61

answered Nov 29 '21 at 17:41

yoyo

137
3
9

score 0 · Answer 6 · answered Jun 02 '23 at 05:43

Add this line at start

View dialog_view= getLayoutInflater().inflate(R.layout.dialog_view, null);
TextInputEditText input = dialog_view.findViewById(R.id.input);

before

AlertDialog.Builder alert = new AlertDialog.Builder(MainActivity.this);

that way a new instance of input is created and avoid the problem

dialog - The specified child already has a parent. You must call removeView() on the child's parent first

6 Answers6

Linked