Escape quotes from Javascript in PHP

Question

I have the following code in PHP and it doesn't work:

echo "<script language=\"javascript\">
function rebuild_preview(){

     var Title = document.getElementById('title').value;
     var LYTtitle = document.getElementById('lyt_title');
     if (LYTtitle !== null){
     document.getElementById('lyt_title').innerHTML = Title.replace(/\r?\n/g, '<br />');
     }
}
</script>";

I think it is because of the quotes in the Title.replace section. Does someone know the correct way to handle it?

If I put alert after the last line it doesn't show up. The code breaks in the if clause. — Gogo, Jun 06 '16 at 08:28
escape the ` \ ` as you want it to be seen as it is. use ` \\ ` — avck, Jun 06 '16 at 08:29
Define _Does not work_ Do you get the script sent to the browser, view using _view page source_? Does it get run in the browser and do the wrong thing?? — RiggsFolly, Jun 06 '16 at 08:30
Also `language="javascript"` has been deprecated for years. See http://stackoverflow.com/a/2267487/2310830 — RiggsFolly, Jun 06 '16 at 08:31

score 0 · Accepted Answer · answered Jun 06 '16 at 08:29

0

Try to use double backslash, one is for php and one for javascript.

 Title.replace(/\\r?\\n/g, '<br />');

answered Jun 06 '16 at 08:29

Niklesh Raut

34,013
16
75
109

score 0 · Answer 2 · answered Jun 06 '16 at 08:37

Doing a simple test using the PHP CLI your code

echo "<script language=\"javascript\">
function rebuild_preview(){

     var Title = document.getElementById('title').value;
     var LYTtitle = document.getElementById('lyt_title');
     if (LYTtitle !== null){
     document.getElementById('lyt_title').innerHTML = Title.replace(/\r?\n/g, '<br />');
     }
}
</script>";

Generates this output

<script language="javascript">
function rebuild_preview(){

     var Title = document.getElementById('title').value;
     var LYTtitle = document.getElementById('lyt_title');
     if (LYTtitle !== null){
?    document.getElementById('lyt_title').innerHTML = Title.replace(/
/g, '<br />');
     }
}

Note the error in the .replace

Amend your document.getElementById like this and it will work

document.getElementById('lyt_title').innerHTML = Title.replace(/\\r?\\n/g, '<br />');

Note the escape \\r and \\n

Escape quotes from Javascript in PHP

2 Answers2