15

I am trying to find the square of a int. My code looks like below:

long long sqr=0;
int num=77778;
sqr= num*num;

The result should have been 6049417284 But when I check the output it shows 1754449988. What is the mistake I am doing? long long should be able to store the result but why am I getting a different value?

Ilya
  • 4,583
  • 4
  • 26
  • 51
srip
  • 617
  • 1
  • 6
  • 18

2 Answers2

10

Intermediate result type is the same as first argument type in this case. So this code puts wrong value into sqr (because here you have integer overflow). Try this:

long long num = 77778;
long long sqr = num * num;

Another way with casting:

int num = 77778;
long long sqr = (long long) num * num;

To understand it better you can check these lines:

int ia = 1, ib = 2;
double da = 1.0, db = 2.0;
double ic = ia / ib; // c == 0.0, because intermediate result of division is 0
double dc = da / db; // c == 0.5, expected result
Ilya
  • 4,583
  • 4
  • 26
  • 51
  • I am trying to understand the mistake in my code. Shouldn't the result be getting stored properly with my code? – srip Jun 10 '16 at 06:07
  • 2
    @rowang The intermediate result before it is stored is the same as the argument types. – Richard Critten Jun 10 '16 at 06:08
  • 1
    @srip, to store the result properly, it has to first compute the result properly. In your code, you are multiplying two ints. So the calculation is done in int itself. So the information is already lost before you store it into the variable. – Sourav Kannantha B Feb 17 '23 at 05:49
6

If you multiply two integer values, the result will be an integer value. Then, the assignment of integer value to long long is meaningless.

So, to get the desired result the num should be long long also.

Md. Monirul Islam
  • 711
  • 6
  • 10