onProgressUpdate not called

Question

Why is onProgressUpdate not being called?

public class DoStuff extends AsyncTask<Integer, Integer, String> {
    private MainActivity activity;

    public DoStuff(MainActivity a){
        activity = a;
    }

    protected String doInBackground(Integer... params) {
        Integer loops = params[0];
        for (int i = 0; i <= loops.intValue() ; i++) {

            SystemClock.sleep(1000);
            publishProgress(new Integer((i / loops) * 100));

        }
        return "Done: " + loops.intValue();
    }

    protected void onProgressUpdate(Integer progress)
    {
        activity.updateProgress("" + progress.intValue() + "%");
    }

}

protected String doInBackground(Integer... params) { Log.d("TEST", "vals "+Arrays.asList(loops)); Integer loops = params[0]; — Martin Pfeffer, Jun 10 '16 at 19:31
In addition to answers, use the `@Override` annotation to help prevent this type of mistake. See [this question](http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why) for more details. — Allan Pereira, Jun 10 '16 at 19:38
Use @Override .... Then compiler will inform you that you didn't override method... Or did it wrong... — Selvin, Jun 10 '16 at 19:39

score 1 · Accepted Answer · answered Jun 10 '16 at 19:31

You are using wrong signature for onProgressUpdate

Change

protected void onProgressUpdate(Integer progress)
{
    activity.updateProgress(""+progress.intValue() +"%");
}

to

protected void onProgressUpdate(Integer... progress)
{
    activity.updateProgress(""+progress[0].intValue() +"%");
}

Giorgio Antonioli · Answer 2 · 2016-06-10T19:38:02.010

1

You have to change:

protected void onProgressUpdate(Integer progress) {
    activity.updateProgress(""+progress.intValue() +"%");
}

to:

protected void onProgressUpdate(Integer... progress) {
   activity.updateProgress(""+progress.intValue() +"%");
}

Parameters must be a varargs of the type that you declared as second

edited Jun 10 '16 at 19:38

answered Jun 10 '16 at 19:32

Giorgio Antonioli

15,771
10
45
70

onProgressUpdate not called

2 Answers2