CheckBox checked on scroll automatically in ListView in android

Question

I am newbie to android and have implemented a listView with checkbox and textViews, I am facing a weird issue of selection.

When I am checking any checkbox, all the other checkbox are automatically checked and it is changed after scrolling randomly.

Can anybody help me what changes should I make to fix this in my code?

ServiceAdapter

package one.tusk.stush.adapters;

import android.content.Context;
import android.content.Intent;
import android.util.SparseBooleanArray;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.BaseAdapter;
import android.widget.CheckBox;
import android.widget.CompoundButton;
import android.widget.TextView;

import com.company.stush.R;

import java.util.ArrayList;
import java.util.HashMap;

import one.tusk.stush.other.Const;

public class ServiceAdapter extends BaseAdapter {
    public ArrayList<HashMap<String, String>> contArray;
    SparseBooleanArray mArray;


    private Context mContext;
    String resnID, reson;
    Intent i;

    public ServiceAdapter(Context paramContext, ArrayList<HashMap<String, String>> contList) {
        this.mContext = paramContext;
        this.contArray = contList;
        mArray = new SparseBooleanArray(contList.size());

    }

    public int getCount() {
        return this.contArray.size();
    }

    public Object getItem(int paramInt) {
        return Integer.valueOf(paramInt);
    }

    public long getItemId(int paramInt) {
        return paramInt;
    }

    public View getView(final int paramInt, View paramView,
            ViewGroup paramViewGroup) {
        LayoutInflater localLayoutInflater = (LayoutInflater) this.mContext
                .getSystemService("layout_inflater");
        Viewholder localViewholder = null;
        Const.selectedIDs.clear();
        if (paramView == null) {
            paramView = localLayoutInflater.inflate(
                    R.layout.raw_single_contact, paramViewGroup, false);
            localViewholder = new Viewholder();

            localViewholder.tv_name = ((TextView) paramView
                    .findViewById(R.id.tv_name));
            localViewholder.chk_id = ((CheckBox) paramView
                    .findViewById(R.id.chk_id));

            paramView.setTag(localViewholder);


        } else {

            localViewholder = (Viewholder) paramView.getTag();
            localViewholder.chk_id.setOnCheckedChangeListener(null);
            localViewholder.chk_id.setChecked(mArray.get(paramInt));
        }
        localViewholder.tv_name.setText(contArray.get(paramInt).get("serviceText"));
        localViewholder.chk_id.setChecked(mArray.get(paramInt));
        //localViewholder.chk_id.setChecked(false);
        //localViewholder.chk_id .setTag(paramInt);

        localViewholder.chk_id.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {

            @Override
            public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
                try {


                    if (isChecked) {
                        Const.selectedIDs.add(contArray.get(paramInt));
                        Const.serviceArrayList.get(paramInt).put("flag", "1");
                    } else {
                        Const.selectedIDs.remove(contArray.get(paramInt));
                        Const.serviceArrayList.get(paramInt).put("flag", "0");
                    }
                }catch (Exception e){
                    e.printStackTrace();
                }

            }
        });




        return paramView;

    }

    static class Viewholder {


    TextView tv_name;
    CheckBox chk_id;


    }



}

V-rund Puro-hit · Accepted Answer · 2016-06-13T11:51:57.300

1

Use SparseBooleanArray instead of ArrayList<Boolean>

SparseBooleanArray mArray;
public ServiceAdapter(Context paramContext, ArrayList<HashMap<String, String>> contList) {
    this.mContext = paramContext;
    this.contArray = contList;
    mArray = new SparseBooleanArray(data.size());

}

And inside getView()

if (convertView == null) {

    localViewholder = new Holder();
    convertView = inflater.inflate(R.layout.item1, null);

    ....
    ....

    convertView.setTag(localViewholder );

} else {
    localViewholder = (Viewholder) convertView.getTag();
    localViewholder.chk_id.setOnCheckedChangeListener(null);
    localViewholder.chk_id.setChecked(mArray.get(position));
}
localViewholder.chk_id.setChecked(mArray.get(position));
localViewholder.chk_id.setOnCheckedChangeListener(new
             OnCheckedChangeListener() {

    @Override
    public void onCheckedChanged(CompoundButton buttonView,boolean isChecked) {
        mArray.put(paramInt, isChecked);
        if (isChecked) {
            Const.selectedIDs.add(isChecked);
            Const.serviceArrayList.get(paramInt).put("flag", "1");
        } else {
            Const.selectedIDs.remove(contArray.get(isChecked));
            Const.serviceArrayList.get(paramInt).put("flag", "0");
        }
    }
});

Happy Coding..

edited Jun 13 '16 at 11:51

answered Jun 13 '16 at 09:14

V-rund Puro-hit

5,518
9
31
50

I have edited my code as per your suggestion,Still no change..!!!Please check my edited code – sulphuric Acid Jun 13 '16 at 10:10
please check `onChackChangeListener` in my code. and put `mArray.put(paramInt, isChecked);` inside it. – V-rund Puro-hit Jun 13 '16 at 11:31
What is "cb" in your code? and what is "chk_id" both are checkboxes? – sulphuric Acid Jun 13 '16 at 11:48
1

I'm sorry.. cb is chk_id. I actually converted my code to yours. but i think i forgot to change there.. check my updated answer.. – V-rund Puro-hit Jun 13 '16 at 11:51
always happy to help .. :) – V-rund Puro-hit Jun 13 '16 at 13:07
-can you help me for one more problem? – sulphuric Acid Jun 14 '16 at 06:16
http://stackoverflow.com/questions/37804336/soft-keyboard-not-open-in-android?noredirect=1#comment63073463_37804336 .please check it – sulphuric Acid Jun 14 '16 at 06:29

score 0 · Answer 2 · answered Jun 13 '16 at 08:49

Change your adapter class code with this

 public class ServiceAdapter extends BaseAdapter {
        public ArrayList<HashMap<String, String>> contArray;
        ArrayList<Boolean> checked;


        private Context mContext;
        String resnID, reson;
        Intent i;

        public ServiceAdapter(Context paramContext, ArrayList<HashMap<String, String>> contList) {
            this.mContext = paramContext;
            this.contArray = contList;
            checked = new ArrayList<>();

        }

        public int getCount() {
            return this.contArray.size();
        }

        public Object getItem(int paramInt) {
            return Integer.valueOf(paramInt);
        }

        public long getItemId(int paramInt) {
            return paramInt;
        }

        public View getView(final int paramInt, View paramView,
                ViewGroup paramViewGroup) {
            LayoutInflater localLayoutInflater = (LayoutInflater) this.mContext
                    .getSystemService("layout_inflater");
            Viewholder localViewholder = null;
            Const.selectedIDs.clear();

                paramView = localLayoutInflater.inflate(
                        R.layout.raw_single_contact, paramViewGroup, false);
                localViewholder = new Viewholder();

                localViewholder.tv_name = ((TextView) paramView
                        .findViewById(R.id.tv_name));
                localViewholder.chk_id = ((CheckBox) paramView
                        .findViewById(R.id.chk_id));

                paramView.setTag(localViewholder);


            localViewholder.tv_name.setText(contArray.get(paramInt).get("serviceText"));
            localViewholder.chk_id.setChecked(false);
            localViewholder.chk_id .setTag(paramInt);

            localViewholder.chk_id.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {

                @Override
                public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
                    try {


                        if (isChecked) {
                            Const.selectedIDs.add(contArray.get(paramInt));
                            Const.serviceArrayList.get(paramInt).put("flag", "1");
                        } else {
                            Const.selectedIDs.remove(contArray.get(paramInt));
                            Const.serviceArrayList.get(paramInt).put("flag", "0");
                        }
                    }catch (Exception e){
                        e.printStackTrace();
                    }

                }
            });




            return paramView;

        }

        static class Viewholder {


        TextView tv_name;
        CheckBox chk_id;


        }



    }

Hello Abhishek,I have used your adapter,But when i am scrolling the listView ti removes the selection..:( — sulphuric Acid, Jun 13 '16 at 10:40

score 0 · Answer 3 · edited Jun 13 '16 at 09:03

0

Try to replace this

localViewholder.chk_id.setChecked(false);

to this

localViewholder.chk_id.setChecked(localViewholder.chk_id.isChecked());

edited Jun 13 '16 at 09:03

V-rund Puro-hit

5,518
9
31
50

answered Jun 13 '16 at 08:52

Khizar Hayat

3,427
3
18
22

CheckBox checked on scroll automatically in ListView in android

3 Answers3