I want to get list of countries from database and bind it to dropdown list

Question

Here is my code gives me error while add countrylist to listofcountries

ERROR

system.collection.generic.list is not assignable to parameter type system.web.mvc.selectListitem

CODE

public List<SelectListItem> Getallcountries()
{
    var listofcountries = new List<SelectListItem>();
    using (var db = new DatabaseContext())
    {
        var countrylist = db.Countries.Where(x => x.IsActive == true).ToList().Select(x => new SelectListItem
        {
            Text = x.CountryName,
            Value = Convert.ToString(x.ID)
        });

       listofcountries.Add(countrylist);
    }
    return listofcountries;
}

http://stackoverflow.com/questions/17727386/dropdownlist-in-mvc-4-with-razor — Amit Kumar Ghosh, Jun 14 '16 at 10:54
@AmitKumarGhosh, That link has nothing to do with OP's issue. — , Jun 14 '16 at 10:54
Remove `listofcountries.Add(countrylist);` and change it to `return countrylist.ToList();` (you query is already generating a collection of `SelectListItem`) — , Jun 14 '16 at 10:56

Akshey Bhat · Accepted Answer · 2016-06-14T10:59:46.967

1

Return the list generated by code directly. No need to add it to another list

public List<SelectListItem> Getallcountries()
{

    using (var db = new DatabaseContext())
    {
        var countrylist = db.Countries.Where(x => x.IsActive == true).ToList().Select(x => new SelectListItem
        {
            Text = x.CountryName,
            Value = Convert.ToString(x.ID)
        });

       return  countrylist.ToList();
    }

}

edited Jun 14 '16 at 10:59

answered Jun 14 '16 at 10:58

Akshey Bhat

8,227
1
20
20

@StephenMuecke Removed the statement – Akshey Bhat Jun 14 '16 at 11:01

score 0 · Answer 2 · answered Jun 14 '16 at 11:05

0

Try This

 using(var db=new dbContect()
  {
      var count=db.Countries.Where(x=>x.IsActive==true).Select(a=>new SelectListItem{
    Text=a.CountyName,
    Value=SqlFunctions.StringConvert(a.ID)
}).ToList();

return count; }

answered Jun 14 '16 at 11:05

Own

174
1
11

I want to get list of countries from database and bind it to dropdown list

2 Answers2