Hide some menu from MenuStrip Winfoms

Question

I have a MenuStrip in my Windows Form Application which Contains MenuItems.

I want to check some condition and disable the visibility of MenuItems in the MenuStrip bar. Suppose Normal User is accessing the application ,then Some MenuItems will be hidden and if Admin user is accessing the application then all MenuItems should be visible.

This is my code (I'am not sure about it ) which didn't work.

  public Visite(string username)
    {
        InitializeComponent();
        label1.Text = username;

        using (SqlConnection con = new SqlConnection("Data Source=ADMIN-PC\\SQLEXPRESS;Initial Catalog=timar;Integrated Security=True"))
        {
            con.Open();
            bool UserIsAdmin = true;
            using (SqlCommand cmd = new SqlCommand("select * from [User] where Role =@Role", con))
            {
                cmd.Parameters.AddWithValue("@Role", "Admin");

                UserIsAdmin = (int)cmd.ExecuteScalar() > 0;
            }
            if (UserIsAdmin == false)
            {
                utilisateurToolStripMenuItem.Visible = false;
            }
           else
           {
               utilisateurToolStripMenuItem.Visible= true;
            }
           con.Close();
       }

    }

Please help. Thanks in advance.

Set utilisateurToolStripMenuItem.Visible = false and not enabled, Enabled will still show you menu — Pankaj, Jun 16 '16 at 08:34

score 0 · Answer 1 · answered Jun 16 '16 at 08:32

0

You are talking about visibility in your question, but your Code says Enabled.

These are two completely different things.

In case you stick with visbility the you should set utilisateurToolStripMenuItem.Visible to false

answered Jun 16 '16 at 08:32

lokusking

7,396
13
38
57

score 0 · Answer 2 · answered Jun 16 '16 at 08:37

0

try This..

public Visite(string username)
{
    InitializeComponent();
    label1.Text = username;
    using (SqlConnection con = new SqlConnection("Data Source=ADMIN-PC\\SQLEXPRESS;Initial Catalog=timar;Integrated Security=True"))
    {
        con.Open();
        bool UserIsAdmin = false;
        using (SqlCommand cmd = new SqlCommand("select * from [User] where Role =@Role", con))
        {
            cmd.Parameters.AddWithValue("@Role", "Admin");
            UserIsAdmin = (int)cmd.ExecuteScalar() > 0;
        }
       utilisateurToolStripMenuItem.Visible = UserIsAdmin;
     }
}

answered Jun 16 '16 at 08:37

Pankaj

2,618
3
25
47

It doesn't work , `utilisateurToolStripMenuItem` still always Visible for all Type of Users – Yosra Chourou Jun 16 '16 at 09:02
@Yosra, Debug and see what is value the of "UserIsAdmin" being returned from database. – Pankaj Jun 16 '16 at 09:04
The value of `UserIsAdmin` is TRUE – Yosra Chourou Jun 16 '16 at 09:11
is this value is TRUE for Normal User also ? – Pankaj Jun 16 '16 at 09:13
Yes , for normal User also – Yosra Chourou Jun 16 '16 at 09:15
which is wrong, this should be FALSE for normal user. That is the reason, It is always visible, change the value in Database and then run the code, your menu will be hidden – Pankaj Jun 16 '16 at 09:16
You are getting confused by what debugger is telilng you. See this.. http://stackoverflow.com/a/15742499/547239 – Pankaj Jun 16 '16 at 09:44
I see the link above and change VISIBLE by AVAILABLE , there is no difference problem persist again The problem in the line `UserIsAdmin = (int)cmd.ExecuteScalar() > 0` , The value of `UserIsAdmin` is True (which should be FALSE) – Yosra Chourou Jun 16 '16 at 10:10

Hide some menu from MenuStrip Winfoms

2 Answers2