Generating different random numbers given same boundaries

Asked Jun 20 '16 at 22:24

Active Jun 20 '16 at 22:39

Viewed 23 times

I'm writing a program that randomly generates a quantified item list for a magic shop.

I have a function that is supposed to generate bounded random quantities depending on the rarity of an item.

public int SetItemQuantity(string Rarity)
        {


            if (Rarity == "Common")
            {
                Random rndQty = new Random();
                int commonQty = rndQty.Next(5, 10);
                return commonQty;
            }

            if (Rarity == "Uncommon")
            {
                Random rndQty = new Random();
                int uncommonQty = rndQty.Next(0, 5);
                return uncommonQty;
            }
            else
                return 0;

The problem is that when this function is later called in a loop and I have two items of the same rarity, they consistently return the same quantities.

edited Jun 20 '16 at 22:39

Camilo Terevinto

31,141
6
88
120

asked Jun 20 '16 at 22:24

Gary Z

1

The duplicate should answer your question, but I thought I'd just check that you understand that your two calls to `.Next` are returning numbers from 5 to 9 and from 0 to 4 respectively? Is that what you're expecting or was it from 5 to 10 and 0 to 5? – Enigmativity Jun 20 '16 at 22:28
Duplicate answered my question and code now works as expected, thanks! – Gary Z Jun 20 '16 at 22:47
1

So you needed 5 to 9 and 0 to 4? – Enigmativity Jun 21 '16 at 00:52
Yes. Thanks for your help! – Gary Z Jun 23 '16 at 17:15

Generating different random numbers given same boundaries

0 Answers0