Andorid Java String - Which is better? "" +, toString(), String.valueOf()?

Question

What is the difference between these in Android / Java? Which is more efficient and what tool did you use to find the differences?

String text = input.getText().toString();

String text = String.valueOf(input.getText());

String text = input.getText() + "";

assuming input is not null...

EDIT: input.getText() returns an Editable.

Possible duplicate of [Integer.toString(int i) vs String.valueOf(int i)](http://stackoverflow.com/questions/3335737/integer-tostringint-i-vs-string-valueofint-i) — Durgpal Singh, Jun 24 '16 at 05:16
see this http://stackoverflow.com/questions/14050845/why-we-use-string-message-edittext-gettext-tostring-after-using-edittext-e — Durgpal Singh, Jun 24 '16 at 05:27
@DurgpalSingh again, that's not related at all to this question... — Nickmccomb, Jun 24 '16 at 05:33
@DurgpalSingh i'm not going to read all the answers when the question is irrelevant because the answers will also be irrelevant. — Nickmccomb, Jun 24 '16 at 05:40

score 3 · Accepted Answer · answered Jun 24 '16 at 05:28

3

Definitely toString().
It clearly states what you want, i.e. to get the String of the returned Editable.

getText() cannot return null, so the null safety of String.valueOf() is not needed, and String.valueOf() simply turns around and calls toString(), so why not just call it directly, since that is shorter?

input.getText() + "" is just lazy and obscure and generates bad code. Sure, JIT may eliminate it, but it's still a hack. (My opinion anyway)

answered Jun 24 '16 at 05:28

Andreas

154,647
11
152
247

That's a better answer. I've always used .toString() but we've been outsourcing and they are all using "" + input.getText() and i've been wondering if it's quicker. I found another post that said it's slower that way, so it seems like toString() is the most efficient and, in my view, elegant solution. – Nickmccomb Jun 24 '16 at 05:35

score 0 · Answer 2 · answered Sep 14 '17 at 18:10

0

toString() is the best method to call. text+"" is the dirty way of coding.

answered Sep 14 '17 at 18:10

Pronoy999

645
6
25

Andorid Java String - Which is better? "" +, toString(), String.valueOf()?

2 Answers2