Is this acceptable to be placed in a view?

Question

Kohana (and probably other frameworks) allow you get a route and echo its URL, creating routes that are easy to maintain.

<a href="<?php echo url::base() . Route::get('contact'); ?>">Contact</a>

Is this OK to have in the view, or should I assign it to a variable, and then pass the view the variable?

Thanks

score 2 · Accepted Answer · answered Sep 27 '10 at 05:01

2

You aren't performing logic here. This is perfectly acceptable.

Of course your view code would be a bit cleaner if you created a variable in your controller, but this really is fine IMHO.

answered Sep 27 '10 at 05:01

Jacob Relkin

161,348
33
346
320

Cool, I always did this but after read Matt's comment to [my answer](http://stackoverflow.com/questions/2393051/favourite-kohana-tips-features/2474278#2474278), I started passing them to view. But it cluttered up my view variables considerably and didn't seem necessary. – alex Sep 27 '10 at 05:17

score 0 · Answer 2 · answered Sep 27 '10 at 05:09

0

I find such a concatenation unnecessary. It seems url::base() going to be used in every link on the site. Why not to have a method to add it automatically? Something like Route::url("contact")
And usage of such a construct in the template is OK.

answered Sep 27 '10 at 05:09

Your Common Sense

156,878
40
214
345

score 0 · Answer 3 · answered Sep 27 '10 at 06:57

0

You can create a function or static method for generating urls:

public static function url($routename, array $params = NULL)
{
   return url::base().Route::get($routename)->uri($params);
}

answered Sep 27 '10 at 06:57

biakaveron

5,493
1
16
20

Calling `url::url()` won't be confusing? – alex Sep 27 '10 at 07:26
It can be another helper, like `common::url()` or `core::url()` :) Usually I dont modify/extend system classes for newfeatures. – biakaveron Sep 27 '10 at 14:42

Is this acceptable to be placed in a view?

3 Answers3