Return two hashmap values from function

Asked Jun 24 '16 at 12:48

Active Jun 24 '16 at 13:59

Viewed 19 times

I have created function which uses one object list and using that list it created two HashMap values:

public HashMap<HashMap<Integer, List<String>>, HashMap<Integer, List<Long>>> getIONameAndId(
        List<LineItemVO> lineItemVOs) {
    HashMap<Integer, List<String>> ioNameMap = new HashMap<>();
    HashMap<Integer, List<Long>> ioIdMap = new HashMap<>();
    HashMap<HashMap<Integer, List<String>>, HashMap<Integer, List<Long>>> ioData =
        new HashMap<>();
    List<Long> ioIds = new ArrayList<Long>();
    List<String> ioNames = new ArrayList<String>();
    for (LineItemVO lineItemVO : lineItemVOs) {
        ioIds.add(lineItemVO.getInsertionOrderId());
        ioNames.add(lineItemVO.getInsertionOrderName());
    }
    ioNameMap.put(1, ioNames);
    ioIdMap.put(1, ioIds);
    ioData.put(ioNameMap, ioIdMap);
    return ioData;
}

I want to simplify this function so it gives exact idea what it returns or should I use Map instead of HashMap?

edited Jun 24 '16 at 13:59

martinez314

12,162
5
36
63

asked Jun 24 '16 at 12:48

Pratik Patel

2,209
3
23
30

2

I smell **object phobia**. Create a meaningful `Object` that holds your two values; if you cannot think of a meaningful object, then you have a problem with your modelling. – Boris the Spider Jun 24 '16 at 12:50
On another note, program to the `interface`. – Boris the Spider Jun 24 '16 at 12:54
@BoristheSpider I don't understand your answer, means I can think of another modeling but I want to use this approach for problem, I want just refactoring – Pratik Patel Jun 24 '16 at 13:27

Return two hashmap values from function

0 Answers0