Var not affected on mysql

Question

Good morning all !

I have a problem with a var in my code :

    <?Php
error_reporting(E_ALL);
  //Si IP correspond pas au PC autorisé, on retourne au debut.
  include "./_protection.php";
  $data='';
  $rep='';
  $requete='';
  $val = '';
  $Reference= '';

echo '<h2><u>Commander des pièces</u></h2><br>';

/*****************************************************************************************************
 *                                  AJOUT DE PIECE DANS LA BASE DE DONNEES
 *****************************************************************************************************/

  if(@$_POST['action'] == "ajouter")
  {
    if(!empty($_POST['choix'])){    
        foreach($_POST['choix'] as $val){
            $Reference.="$val,"; 
        }

    //Injection dans la base SQL
    include "./../connexion.inc";
    mysql_query("INSERT INTO `tbl_commandes` ( `id`, `Eleve`, `Reference`, `Quantite`, `Date`, `Statut` )
VALUES ( '', '".$_POST['Eleve']."', '".$_POST['Reference']."', '".$_POST['Quantite']."', '".$_POST['Date']."', '".$_POST['Statut']."' )");
    mysql_close();
    }
  } 


/*****************************************************************************************************
 *                                  FORMULAIRE POUR L'AJOUT DE PIECE
 *****************************************************************************************************/
echo '
<fieldset>
    <legend>Commander des Pièces</legend>
    <FORM action="./?page=commande_piece_full_php" method="POST">
        <p align="left">
        <H2>Pièces :</h2>
        <br>';
        echo $Reference;
        include "./../connexion.inc";
        $rep = mysql_query("SELECT id_categorie_piece, categorie_piece FROM tbl_categorie_piece ORDER BY categorie_piece");
        mysql_close();
        include "./../connexion.inc";
        while($data = mysql_fetch_array($rep))
            {
            echo $data['categorie_piece'];
            echo '<br>';
            $requete = $data['id_categorie_piece'];
            $reponse = mysql_query("SELECT id_piece, piece FROM tbl_piece WHERE idr_categorie_piece='$requete' ORDER BY piece");
            while($donnees = mysql_fetch_array($reponse)){
                ?> <input type="checkbox" name="choix[]" value="<? echo $donnees['id_piece'] ?>"><? echo $donnees['piece'] ?><br> <?
                }
            echo '<br>';
            }
        mysql_close();
echo '
    Elève : 
    <select name="Eleve">';
        include "./../connexion.inc";
        $reponse2 = mysql_query("SELECT id_client, client FROM tbl_client ORDER BY client");
        while($donnees2 = mysql_fetch_array($reponse2))
        {
            ?> <option value="<? echo $donnees2['client'] ?>"><? echo $donnees2['client'] ?></option> <?
        }
        mysql_close();
    echo '
    </select>
    <br>
    Date souhaitée : <input type="textbox" name="Date">
    <br>
    Quantité : <input type="textbox" name="Quantite">
    <br>
    <input type="submit" value="ajouter">
    <input type="hidden" name="action" value="ajouter">
    </form>
</fieldset>';

?>

my var $reference is Ok, i can echo $reference; and get the content rightly BUT when i wanna send $reference to my mysql table .. that doesn't send it When i submit, i get this notice from the parser : Notice:

Undefined index: Reference in /home/bddstock/www/admin/commande_piece_full_php.php on line 27

but when it is submited i get the right content in my echo line under PIECES so i really don't understand .. can someone help me ?

score 1 · Accepted Answer · edited May 23 '17 at 11:58

1

Change your insert statement to

mysql_query("INSERT INTO `tbl_commandes` ( `id`, `Eleve`, `Reference`,    
`Quantite`, `Date`, `Statut` )
VALUES ( '', '".$_POST['Eleve']."', '".$Reference."', '".$_POST['Quantite']."', '".$_POST['Date']."', '".$_POST['Statut']."' )");

i.e change $_POST['Reference'] to $Reference as you have not posted this field and it seems you derive it from looping $_POST['choix'].

Note : use mysqli instead of mysql and refer How can I prevent SQL injection in PHP?

edited May 23 '17 at 11:58

Community

1
1

answered Jun 27 '16 at 11:10

jitendrapurohit

9,435
2
28
39

Really thanks you ! It works ! i will use Mysqli or may PDO, wich one is more easier to convert to ? – Khaleesi Jun 27 '16 at 12:15
Both are quite easier to understand, but I recommend to use PDO. Refer http://stackoverflow.com/questions/31311607/please-how-to-convert-mysql-query-to-pdo-in-my-code – jitendrapurohit Jun 27 '16 at 12:28
@Khaleesi if the posted answer fixed your issue, you can accept it as an answer. – jitendrapurohit Jun 27 '16 at 12:29

Var not affected on mysql

1 Answers1