get rid of last comma in a loop in php

Question

I'm trying to send mulitple sms and the correct format for the api to send the text messages should be (00,001,002) but with my current sql it produces this results (00,001,002,)

How can i correct my script to get this results (00,001,002)

$query_rs_p = "SELECT * FROM contacts ORDER BY id DESC";
$rs_p = mysql_query($query_rs_p, $insurance) or die(mysql_error());
$row_rs_p = mysql_fetch_assoc($rs_p);
$totalRows_rs_p = mysql_num_rows($rs_p);
$ph=',';
do {
echo $row_rs_p['phone_number'].$ph;
} while ($row_rs_p = mysql_fetch_assoc($rs_p));

http://stackoverflow.com/questions/3120398/php-how-to-remove-any-last-commas — B.Kocaman, Jun 28 '16 at 15:28
`while(...) { $arr[] = $row['number']; } echo implode(',' $arr)` as an alternative. — Marc B, Jun 28 '16 at 15:35

score 2 · Accepted Answer · edited Jun 28 '16 at 15:42

Instead of echoing it out in your loop, put it all in a string. Then trim off the last comma before you output it:

$query_rs_p = "SELECT * FROM contacts ORDER BY id DESC";
$rs_p = mysql_query($query_rs_p, $insurance) or die(mysql_error());
$row_rs_p = mysql_fetch_assoc($rs_p);
$totalRows_rs_p = mysql_num_rows($rs_p);
$ph=',';
$string = '';
do {
$string .= $row_rs_p['phone_number'].$ph;
} while ($row_rs_p = mysql_fetch_assoc($rs_p));
$string = rtrim($string, ',');
echo $string;

Or, better yet, just build this string in your query. Much simpler and cleaner:

$query_rs_p = "SELECT group_concat(phone_number) as phine_numbers FROM contacts ORDER BY id DESC";
$rs_p = mysql_query($query_rs_p, $insurance) or die(mysql_error());
$row_rs_p = mysql_fetch_assoc($rs_p);
echo $row['phone_numbers'];

you answer work but check the spelling of the trin and change to trim — neiza, Jun 28 '16 at 15:35

score 1 · Answer 2 · answered Jun 28 '16 at 15:29

1

Use rtrim function

$rowsphone =  $row_rs_p['phone_number'].$ph;
rtrim($rowsphone,',');

answered Jun 28 '16 at 15:29

I'm Geeker

4,601
5
22
41

score 0 · Answer 3 · answered Jun 28 '16 at 15:29

0

Probably the most direct would be to just do something like this:

$output = '';
do {
    if ($output != '')
        $output .= ',';
    $output .= $row_rs_p['phone_number'];
while ($row_rs_p = mysql_fetch_assoc($rs_p);

echo $output;

answered Jun 28 '16 at 15:29

VoteyDisciple

37,319
5
97
97

get rid of last comma in a loop in php

3 Answers3