JUnit - SQLException, how to get coverage?

Question

I know I can use Mockito to force an exception throw from DAO methods, but how can I get test coverage inside the DAO class properly?

Example:

public static void addUser(int userId, int groupId)
        throws DataSourceException {
    String query = "INSERT INTO RUserGroup (userId, groupId) VALUES (?, ?)";
    Connection connection = Pool.getInstance().getConnection();
    try (PreparedStatement ps = connection.prepareStatement(query);) {
    // ...
    } catch (SQLException e) {
        throw new DataSourceException(e);
    } finally {
        Pool.getInstance().returnConnection(connection);
    }
}

How can I reach the "throw new DataSourceException(e)"? I have a lot of those cases in the code and they completely ruin branch coverage. I am using JaCoCo for the coverage.

This looks hard to test due to reliance on a static method to provide the dependency, rather than DI. — Oliver Charlesworth, Jul 02 '16 at 17:18

score 0 · Answer 1 · edited May 23 '17 at 12:32

0

The problem is mocking the Pool.getInstance() method, since you want your connection to be a mock, since you could then let it throw exceptions if necessary.
Mockito doesn't let you do that.

For such cases, See Mocking static methods with Mockito

edited May 23 '17 at 12:32

Community

1
1

answered Jul 02 '16 at 17:32

Koos Gadellaa

1,220
7
17

JUnit - SQLException, how to get coverage?

1 Answers1