Program stuck in loop while checking value is int or string

Question

I'm trying to find that entered value from the user is String or Int,but program stuck in a loop when a user entered any string.Can I delete int taxableIncomevalue one-time execution if yes then how ? I'm beginner level programmer... tell me anyway within that I can check Value from user is int or string.... here is code

int taxableIncome;

for (;;) {
    cout << "Please enter in your taxable income: ";
    if (cin >> taxableIncome) {
        cout << "Your income: " << taxableIncome;
        break;
    } else {
        cout << "Please enter a valid integer" << endl;
    }
}

"delete taxableIncome" - this is completely bogus. "taxableIncome" was not allocated with `new`. It is not even a pointer. Does that even compile?? — Jesper Juhl, Jul 02 '16 at 17:33
"Ur income" - if you can't even be bothered to spell "Your" correctly then I can't be bothered to look at your code any more.. — Jesper Juhl, Jul 02 '16 at 17:35
Oh that was my last try to run program.....i have removed it now...thanx — Kamal Mrock, Jul 02 '16 at 17:36

score 3 · Answer 1 · answered Jul 02 '16 at 17:47

Once cin >> taxableIncome fails (which you're detecting) further reads from cin will fail directly because the stream is already flagged with its bad bit. You need to clear that bit, munch the rest of the line, and try again.

int taxableIncome;

for (;;) {
    cout << "Please enter in your taxable income: ";
    if (cin >> taxableIncome) {
        cout << "Your income: " << taxableIncome;
        break;
    } else {
        cout << "Please enter a valid integer" << endl;
        cin.clear();
        cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n');
    }
}

I like the use of the technical term, *munch*. + 1 – Thomas Matthews Jul 02 '16 at 17:59 — Thomas Matthews, Jul 02 '16 at 17:59

Program stuck in loop while checking value is int or string

1 Answers1