How can i pass the form values to ChangePassword.php?

Question

I would like to pass the oldPassword, newPassword, newPasswordAgain values to ChangePassword.php after I checked the validity of the data with a javascript function. Here is the form and the javascript:

<?php
session_start();
?>

<!DOCTYPE html>
<html>
    <head>
        <link rel="stylesheet" type="text/css" href="../style/style.css">
    </head>
    <body>
        <div class="navbar">
            <ul>
                <li><a href="../Pages/Main.php">Home</a></li>
                <li><a href="../Pages/Rules.php">Rules</a></li>
                <li><a href="../Pages/Builds.php">Builds</a></li>
                <li><a href="../Pages/Events.php">Events</a></li>
                <li><a href="../Pages/Calendar.php">Calendar</a></li>
                <li style="float:right"><a class="active" href="../Pages/UserSettings.php"><?php echo $_SESSION["username"]; ?></a></li>
            </ul>
        </div>

        <div class="changepasswd_bg">
            <div class="absolute">

                <form name="changePasswordForm"   method=POST action="../Pages/ChangePassword.php"  onsubmit="return validateForm()">
                    <input  type="password" name="oldPassword"  placeholder="Old password" size="100"><br>
                    <input  type="password" name="newPassword"  placeholder="New password" size="100"><br>
                    <input  type="password" name="newPasswordAgain"  placeholder="New password again" size="100"><br>
                    <input type="submit" value="Change" size="70">

                </form>

                <h2 id="output"></h2><br>
                <h2 id="debug"></h2>
            </div>

        </div>

        <script>
            function validateForm() {

                var oldX = document.forms["changePasswordForm"]["oldPassword"].value;
                var newX = document.forms["changePasswordForm"]["newPassword"].value;
                var newXAgain = document.forms["changePasswordForm"]["newPasswordAgain"].value;

                //ki kell tölteni a mezőket
                if (oldX === null || oldX === "" || newX === null || newX === "" || newXAgain === null || newXAgain === "") {
                    document.getElementById("output").innerHTML = "All field need to fill";
                    document.getElementById("debug").innerHTML = masterPass;
                    return false;
                } // a régi passwordnek a megadottal egyezni kell 
                else if ('<?php echo $_SESSION["password"] ?>'.toString() !== oldX.toString()) {
                    document.getElementById("output").innerHTML = "The original passwords are not matches";
                    return false;
                } else if (newX !== newXAgain) {
                    document.getElementById("output").innerHTML = "The new passwords are not matches";
                    return false;
                } else {

                    document.getElementById("output").innerHTML = "OK";
                    return true;
                }
            }
        </script>


    </body>

</html>

And here is the ChangePassword.php:

<?php
session_start();
?>

<!DOCTYPE html>

<?php
include '../Database/Connect.php';

$oldPassword = $_GET["oldPassword"];
$newPassword = $_GET["newPassword"];
$newPasswordAgain = $_GET["newPasswordAgain"];
if (strlen($oldPassword) == 0 || strlen($newPassword) == 0 || strlen($newPasswordAgain) == 0) {
    echo "valamelyik 0 hosszu";
    echo $_SESSION["password"] . " " . $oldPassword . " " . $newPassword . "  " . $newPasswordAgain;
    //header("Location: ../Pages/SomethingWrong.php");
} else if ($_SESSION["password"] !== $oldPassword) {
    echo "a session és az ild password nem egyezik";
    echo $_SESSION["password"] . " " . $oldPassword . " " . $newPassword . "  " . $newPasswordAgain;
    // header("Location: ../Pages/SomethingWrong.php");
} else if ($newPassword !== $newPasswordAgain) {
    echo "a két password nem egyezik";
    echo $_SESSION["password"] . " " . $oldPassword . " " . $newPassword . "  " . $newPasswordAgain;
    // header("Location: ../Pages/SomethingWrong.php");
} else {
    echo "minden ok " . $_SESSION["password"] . " " . $oldPassword . " " . $newPassword . "  " . $newPasswordAgain;

}
?>

The result is these errors: (also i cant see on the header the variable values. like: http://ChangePassword.php?name=value ... etc)

Notice: Undefined index: oldPassword in D:\apache\htdocs\Pages\ChangePassword.php on line 10

Notice: Undefined index: newPassword in D:\apache\htdocs\Pages\ChangePassword.php on line 11

Notice: Undefined index: newPasswordAgain in D:\apache\htdocs\Pages\ChangePassword.php on line 12

valamelyik 0 hosszuEzredes123

@Fred-ii- PC On a go slow today. Took 2 mins to post that answer, as it was same as other I got rid — RiggsFolly, Jul 04 '16 at 12:09
@RiggsFolly You should have kept yours. You were 2nd, then all others started rolling in like oranges!! I feel yours was better explained. — Funk Forty Niner, Jul 04 '16 at 12:10
Please don't store passwords in a session variable. And as a user I really don't appreciate having my passwords echoed out to the screen either... — jeroen, Jul 04 '16 at 12:11
@RiggsFolly Ah, with an *"all-mightly stroke!"*. Don't go putting red next to blue now ;-) — Funk Forty Niner, Jul 04 '16 at 12:19

score 2 · Answer 1 · answered Jul 04 '16 at 12:07

2

your using $_GET but your method is post. so change it to $_POST

answered Jul 04 '16 at 12:07

hungrykoala

1,083
1
13
28

score 2 · Accepted Answer · edited May 23 '17 at 11:45

2

You need to use $_POST for your scenario

$oldPassword = $_POST["oldPassword"];
$newPassword = $_POST["newPassword"];
$newPasswordAgain = $_POST["newPasswordAgain"];

Passing sensitive information:

It is safer to use an SSL socket when passing sensitive information over the Internet.

For more information on this, consult the following on Stack:

edited May 23 '17 at 11:45

Community

1
1

answered Jul 04 '16 at 12:09

Mohan Raj

447
1
5
18

1

Highly credential? :-) – jeroen Jul 04 '16 at 12:22
Yaeh.. Mr. Jeroen. Am just trying to say that we need to use form method $_POST instead $_GET – Mohan Raj Jul 04 '16 at 12:24
2

@jeroen and Mohan. I made a slight edit to the answer. – Funk Forty Niner Jul 04 '16 at 12:44
1

Yaeh. That was great. – Mohan Raj Jul 04 '16 at 12:46

How can i pass the form values to ChangePassword.php?

2 Answers2