Update CGRectMake to CGRect in Swift 3 Automatically

Question

Now that CGRectMake , CGPointMake, CGSizeMake, etc. has been removed in Swift 3.0, is there any way to automatically update all initializations like from CGRectMake(0,0,w,h) to CGRect(x:0,y:0,width:w,height:h). Manual process is.. quite a pain.

Not sure why Apple don't auto convert this when I convert the code to Current Swift Syntax...

Convert to Current Swift Syntax works for me and converts `CGRectMake(0,0,w,h)` to `CGRect(x: 0,y: 0,width: w,height: h)`. If it does not work in your case then you should file a bug report. — Martin R, Jul 12 '16 at 17:12

score 79 · Answer 1 · answered Jul 12 '16 at 17:12

79

The simplest solution is probably just to redefine the functions Apple took away. Example:

func CGRectMake(_ x: CGFloat, _ y: CGFloat, _ width: CGFloat, _ height: CGFloat) -> CGRect {
    return CGRect(x: x, y: y, width: width, height: height)
}

Put that in your module and all calls to CGRectMake will work again.

answered Jul 12 '16 at 17:12

rob mayoff

375,296
67
796
848

hmm that's cool! let me see what others think; else, I'll accept yours as answers! – yonasstephen Jul 12 '16 at 17:14
I've been waiting for PaintCode to update to Swift 3. With all the `CGRectMake`s in there, this was by far the best solution. – D. Greg Sep 15 '16 at 04:51
Why is there a CGRectMake in the first place if you can init with CGRect the same way, i don't get it – thibaut noah Jan 06 '17 at 20:27
There used to be `CGRectMake` because Apple hadn't fine-tuned the way Core Graphics is imported into Swift. They now have, so `CGRectMake` is not available in current Swift releases. – rob mayoff Jan 06 '17 at 21:47
Obj-C people suffering the migration to Swift :-) That solution is quick and dirty. I'd to it for a quick port. But if you're using Swift, better to just use the paradigm. Not as bad as it seems at first. If I was really bugged by labels, I'd make an extension. Kind of what you get used to. I've gone back and forth over my career with cryptic/terse vs. long/labeled and they both have advantages. Labels overall make code much easier to maintain and reverse engineer, because after awhile away you do forget and it's a hassle to have to look up every function just to figure out unnamed arguments. – clearlight Oct 20 '19 at 17:45

score 32 · Answer 2 · answered Jul 13 '16 at 20:35

32

Short answer: don't do it. Don't let Apple boss you around. I hate CGRect(x:y:width:height:). I've filed a bug on it. I think the initializer should be CGRect(_:_:_:_:), just like CGRectMake. I've defined an extension on CGRect that supplies it, and plop that extension into every single project the instant I start.

extension CGRect {
    init(_ x:CGFloat, _ y:CGFloat, _ w:CGFloat, _ h:CGFloat) {
        self.init(x:x, y:y, width:w, height:h)
    }
}

That way, all I have to do is change "CGRectMake" to "CGRect" everywhere, and I'm done.

answered Jul 13 '16 at 20:35

matt

515,959
87
875
1,141

1

Thanks for this great helpful answer... You saved my time. – Sourabh Sharma Oct 12 '16 at 13:02
where can i add this extension? rather, how do i use it? thanks – nights Feb 20 '17 at 10:02
1

@nights, outside any class – Toma Feb 27 '17 at 16:57

score 19 · Accepted Answer · answered Jul 12 '16 at 19:04

19

Apple actually does provide this feature. All you have to do is go to:

Edit > Convert > To Latest Swift Syntax...

And then follow the onscreen prompts.

This will solve your syntax issues and you won't have to make new functions for all of the various removed functions.

answered Jul 12 '16 at 19:04

Wyetro

8,439
9
46
64

1

it does yeah! for some reasons when I first convert, some files didn't get converted. But when I ran again, it did! I guess must run multiple times until all your files get converted.. – yonasstephen Jul 13 '16 at 01:23
it doesnt do it for me, i've more than once and even after making some changes. – nights Feb 20 '17 at 10:06

Update CGRectMake to CGRect in Swift 3 Automatically

3 Answers3

Linked

Related